Changeset 57345 for trunk/tests/phpunit/tests/script-modules/wpScriptModules.php

Timestamp:

01/24/2024 10:37:54 AM (9 months ago)

Author:

youknowriad

Message:

Script Loader: Load the modules to the footer in classic themes

Incremental import maps fail if the import map is printed after the module scripts.
This means, we should always render import maps first. This means that for classic themes, we need to move the import map and modules to the footer because we can't know before that which modules are needed.

Props luisherranz, cbravobernal.
Fixes #60240.

File:

• trunk/tests/phpunit/tests/script-modules/wpScriptModules.php (modified) (1 diff)

trunk/tests/phpunit/tests/script-modules/wpScriptModules.php

@@ -518 +518 @@
 
     /**
-     * Tests that it can print the enqueued script modules multiple times, and it
-     * will only print the script modules that have not been printed before.
-     *
-     * @ticket 56313
-     *
-     * @covers ::register()
-     * @covers ::enqueue()
-     * @covers ::print_enqueued_script_modules()
-     */
-    public function test_print_enqueued_script_modules_can_be_called_multiple_times() {
-        $this->script_modules->register( 'foo', '/foo.js' );
-        $this->script_modules->register( 'bar', '/bar.js' );
-        $this->script_modules->enqueue( 'foo' );
-
-        $enqueued_script_modules = $this->get_enqueued_script_modules();
-        $this->assertCount( 1, $enqueued_script_modules );
-        $this->assertTrue( isset( $enqueued_script_modules['foo'] ) );
-
-        $this->script_modules->enqueue( 'bar' );
-
-        $enqueued_script_modules = $this->get_enqueued_script_modules();
-        $this->assertCount( 1, $enqueued_script_modules );
-        $this->assertTrue( isset( $enqueued_script_modules['bar'] ) );
-
-        $enqueued_script_modules = $this->get_enqueued_script_modules();
-        $this->assertCount( 0, $enqueued_script_modules );
-    }
-
-    /**
-     * Tests that it can print the preloaded script modules multiple times, and it
-     * will only print the script modules that have not been printed before.
-     *
-     * @ticket 56313
-     *
-     * @covers ::register()
-     * @covers ::enqueue()
-     * @covers ::print_script_module_preloads()
-     */
-    public function test_print_preloaded_script_modules_can_be_called_multiple_times() {
-        $this->script_modules->register( 'foo', '/foo.js', array( 'static-dep-1', 'static-dep-2' ) );
-        $this->script_modules->register( 'bar', '/bar.js', array( 'static-dep-3' ) );
-        $this->script_modules->register( 'static-dep-1', '/static-dep-1.js' );
-        $this->script_modules->register( 'static-dep-3', '/static-dep-3.js' );
-        $this->script_modules->enqueue( 'foo' );
-
-        $preloaded_script_modules = $this->get_preloaded_script_modules();
-        $this->assertCount( 1, $preloaded_script_modules );
-        $this->assertTrue( isset( $preloaded_script_modules['static-dep-1'] ) );
-
-        $this->script_modules->register( 'static-dep-2', '/static-dep-2.js' );
-        $this->script_modules->enqueue( 'bar' );
-
-        $preloaded_script_modules = $this->get_preloaded_script_modules();
-        $this->assertCount( 2, $preloaded_script_modules );
-        $this->assertTrue( isset( $preloaded_script_modules['static-dep-2'] ) );
-        $this->assertTrue( isset( $preloaded_script_modules['static-dep-3'] ) );
-
-        $preloaded_script_modules = $this->get_preloaded_script_modules();
-        $this->assertCount( 0, $preloaded_script_modules );
-    }
-
-    /**
      * Tests that a script module is not registered when calling enqueue without a
      * valid src.