Changeset 57357 for trunk/src/wp-includes/canonical.php

Timestamp:

01/25/2024 05:34:54 PM (22 months ago)

Author:

jorbin

Message:

Media: Redirect inactive attachment pages for logged-out users.

Ensure logged out users are redirected to the media file when attachment pages are inactive. This removes the read_post capability check from the canonical redirects as anonymous users lack the permission.

This was previously committed in [57310] before being reverted in [57318]. This update includes a fix to cover instances where revealing a URL could be considered a data leak and greatly expands the unit tests to ensure that this is covered along with many other instances.

Follow-up to [56657], [56658], [56711], [57310], [57318].

Props peterwilsoncc, jorbin, afercia, aristath, chesio, joppuyo, jorbin, lakshmananphp, poena, sergeybiryukov, swissspidy, johnbillion.
Fixes #59866.
See #57913.

File:

• trunk/src/wp-includes/canonical.php (modified) (1 diff)

trunk/src/wp-includes/canonical.php

@@ -551 +551 @@
 
     if ( is_attachment() && ! get_option( 'wp_attachment_pages_enabled' ) ) {
-        $attachment_id = get_query_var( 'attachment_id' );
-
-        if ( current_user_can( 'read_post', $attachment_id ) ) {
-            $redirect_url = wp_get_attachment_url( $attachment_id );
-
-            $is_attachment_redirect = true;
-        }
+        $attachment_id        = get_query_var( 'attachment_id' );
+        $attachment_post      = get_post( $attachment_id );
+        $attachment_parent_id = $attachment_post ? $attachment_post->post_parent : 0;
+
+        $attachment_url = wp_get_attachment_url( $attachment_id );
+        if ( $attachment_url !== $redirect_url ) {
+            /*
+            * If an attachment is attached to a post, it inherits the parent post's status. Fetch the
+            * parent post to check its status later.
+            */
+            if ( $attachment_parent_id ) {
+                $redirect_obj = get_post( $attachment_parent_id );
+            }
+            $redirect_url = $attachment_url;
+        }
+
+        $is_attachment_redirect = true;
     }