Changeset 57380

Timestamp:

01/30/2024 08:37:04 AM (3 months ago)

Author:

swissspidy

Message:

REST API: Support assigning terms when creating attachments.

Props mukesh27, Dharm1025, Ankit K Gupta, swissspidy, dharm1025, tanjimtc71, timothyblynjacobs, spacedmonkey.
Fixes #57897.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

@@ -185 +185 @@
         if ( is_wp_error( $fields_update ) ) {
             return $fields_update;
+        }
+
+        $terms_update = $this->handle_terms( $attachment_id, $request );
+
+        if ( is_wp_error( $terms_update ) ) {
+            return $terms_update;
         }
 

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -1044 +1044 @@
         $attachment = $response->get_data();
         $this->assertStringNotContainsString( ABSPATH, get_post_meta( $attachment['id'], '_wp_attached_file', true ) );
+    }
+
+    /**
+     * @ticket 57897
+     *
+     * @requires function imagejpeg
+     */
+    public function test_create_item_with_terms() {
+        wp_set_current_user( self::$author_id );
+        register_taxonomy_for_object_type( 'category', 'attachment' );
+        $category = wp_insert_term( 'Media Category', 'category' );
+        $request  = new WP_REST_Request( 'POST', '/wp/v2/media' );
+        $request->set_header( 'Content-Type', 'image/jpeg' );
+        $request->set_header( 'Content-Disposition', 'attachment; filename=canola.jpg' );
+
+        $request->set_body( file_get_contents( self::$test_file ) );
+        $request->set_param( 'categories', array( $category['term_id'] ) );
+        $response   = rest_get_server()->dispatch( $request );
+        $attachment = $response->get_data();
+
+        $term = wp_get_post_terms( $attachment['id'], 'category' );
+        $this->assertSame( $category['term_id'], $term[0]->term_id );
     }