Changeset 57386 for trunk/tests/phpunit/tests/l10n/wpTranslationsConvert.php

Timestamp:

01/30/2024 01:59:46 PM (23 months ago)

Author:

swissspidy

Message:

I18N: Improve singular lookup of pluralized strings.

Ensures that looking up a singular that is also used as a pluralized string works as expected.
This improves compatibility for cases where for example both __( 'Product' ) and _n( 'Product', 'Products’, num ) are used in a project, where both will use the same translation for the singular version.

Although such usage is not really recommended nor documented, it must continue to work in the new i18n library in order to maintain backward compatibility and maintain expected behavior.

See #59656.

File:

• trunk/tests/phpunit/tests/l10n/wpTranslationsConvert.php (modified) (2 diffs)

trunk/tests/phpunit/tests/l10n/wpTranslationsConvert.php

@@ -174 +174 @@
      * @covers ::locate_translation
      * @covers ::get_files
+     * @covers WP_Translation_File::translate
      *
      * @dataProvider data_simple_example_files
@@ -199 +200 @@
         $this->assertSame( 'translation0 with context', $controller->translate_plural( array( 'plural0 with context', 'plural1 with context' ), 1, 'context', 'unittest' ) );
         $this->assertSame( 'translation1 with context', $controller->translate_plural( array( 'plural0 with context', 'plural1 with context' ), 2, 'context', 'unittest' ) );
+
+        $this->assertSame( 'Produkt', $controller->translate( 'Product', '', 'unittest' ) );
+        $this->assertSame( 'Produkt', $controller->translate_plural( array( 'Product', 'Products' ), 1, '', 'unittest' ) );
+        $this->assertSame( 'Produkte', $controller->translate_plural( array( 'Product', 'Products' ), 2, '', 'unittest' ) );
     }