Changeset 57506 for trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php

Timestamp:

02/01/2024 12:10:19 AM (2 years ago)

Author:

dmsnell

Message:

HTML API: Fix CDATA lookalike matching invalid CDATA

When next_token() was introduced to the HTML Tag Processor, it started
classifying comments that look like they were intended to be CDATA sections.
In one of the changes made during development, however, a typo slipped
through code review that treated comments as CDATA even if they only
ended in ]> and not the required ]]>.

The consequences of this defect were minor because in all cases these are
treated as HTML comments from invalid syntax, but this patch adds the
missing check to ensure the proper reporting of CDATA-lookalikes.

Follow-up to [57348]

Props jonsurrell
Fixes #60406

File:

• trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php (modified) (1 diff)

trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php

@@ -1763 +1763 @@
                     'A' === $html[ $this->token_starts_at + 7 ] &&
                     '[' === $html[ $this->token_starts_at + 8 ] &&
-                    ']' === $html[ $closer_at - 1 ]
+                    ']' === $html[ $closer_at - 1 ] &&
+                    ']' === $html[ $closer_at - 2 ]
                 ) {
                     $this->parser_state    = self::STATE_COMMENT;