Changeset 57513 for trunk/src/wp-includes/l10n/class-wp-translation-file-php.php

Timestamp:

02/01/2024 11:43:21 AM (2 years ago)

Author:

swissspidy

Message:

I18N: Improve singular lookup of pluralized strings.

Ensures that string lookup in MO files only uses the singular string.

This matches expected behavior with gettext files and improves compatibility for cases where for example both __( 'Product' ) and _n( 'Product', 'Products’, num ) are used in a project, where both will use the same translation for the singular version. Maintains backward compatibility and feature parity with the pomo library and the PHP translation file format.

Replaces [57386], which was reverted in [57505], with a more accurate and performant solution.

See #59656.

File:

• trunk/src/wp-includes/l10n/class-wp-translation-file-php.php (modified) (1 diff)

trunk/src/wp-includes/l10n/class-wp-translation-file-php.php

@@ -29 +29 @@
 
         if ( isset( $result['messages'] ) && is_array( $result['messages'] ) ) {
-            foreach ( $result['messages'] as $singular => $translations ) {
-                if ( is_array( $translations ) ) {
-                    $this->entries[ $singular ] = implode( "\0", $translations );
-                } elseif ( is_string( $translations ) ) {
-                    $this->entries[ $singular ] = $translations;
-                }
+            foreach ( $result['messages'] as $original => $translation ) {
+                $this->entries[ (string) $original ] = $translation;
             }
             unset( $result['messages'] );