Changeset 57526 for trunk/tests/phpunit/tests/block-bindings/register.php

Timestamp:

02/02/2024 08:22:11 PM (2 years ago)

Author:

gziolo

Message:

Editor: Refactor the way block bindings sources are handled

It fixes the coding style issues reported. It goes further and improves the code quality it other places where the logic for block bindings was added.

Follow-up for [57514].
Props: gziolo, mukesh27, youknowriad, santosguillamot.
See #60282.

File:

• trunk/tests/phpunit/tests/block-bindings/register.php (modified) (4 diffs)

trunk/tests/phpunit/tests/block-bindings/register.php

@@ -18 +18 @@
 
     /**
-     * Set up before each test.
-     *
-     * @since 6.5.0
-     */
-    public function set_up() {
-        foreach ( get_all_registered_block_bindings_sources() as $source_name => $source_properties ) {
-            unregister_block_bindings_source( $source_name );
-        }
-
-        parent::set_up();
-    }
-
-    /**
      * Tear down after each test.
      *
@@ -37 +24 @@
     public function tear_down() {
         foreach ( get_all_registered_block_bindings_sources() as $source_name => $source_properties ) {
-            unregister_block_bindings_source( $source_name );
+            if ( str_starts_with( $source_name, 'test/' ) ) {
+                unregister_block_bindings_source( $source_name );
+            }
         }
 
@@ -50 +39 @@
      * @covers ::register_block_bindings_source
      * @covers ::get_all_registered_block_bindings_sources
+     * @covers ::get_block_bindings_source
      */
     public function test_get_all_registered() {
@@ -65 +55 @@
 
         $expected = array(
-            $source_one_name   => array_merge( array( 'name' => $source_one_name ), $source_one_properties ),
-            $source_two_name   => array_merge( array( 'name' => $source_two_name ), $source_two_properties ),
-            $source_three_name => array_merge( array( 'name' => $source_three_name ), $source_three_properties ),
+            $source_one_name         => array_merge( array( 'name' => $source_one_name ), $source_one_properties ),
+            $source_two_name         => array_merge( array( 'name' => $source_two_name ), $source_two_properties ),
+            $source_three_name       => array_merge( array( 'name' => $source_three_name ), $source_three_properties ),
+            'core/post-meta'         => get_block_bindings_source( 'core/post-meta' ),
+            'core/pattern-overrides' => get_block_bindings_source( 'core/pattern-overrides' ),
         );
 
         $registered = get_all_registered_block_bindings_sources();
-        $this->assertSame( $expected, $registered );
+        $this->assertEquals( $expected, $registered );
     }