Changeset 57528

Timestamp:

02/02/2024 11:25:56 PM (2 years ago)

Author:

dmsnell

Message:

HTML API: Fix typo setting the wrong self-closing flag.

The HTML Processor tracks whether a token was found with the self-closing flag.
Depending on the context, this flag may or may not indicate that the element is
self closing. Unfortunately it's been tracking the wrong flag: it's been tracking
the end-tag flag, which indicates that a token is an end tag.

In this patch the right flag is set in the HTML Processor. This hasn't been an
issue because the HTML Processor doesn't yet read that stored flag, but it's an
important fix to make before adding support for foreign content (SVG and MathML)
since that behavior depends on reading the correct flag.

Follow-up to [56274].

Props dmsnell.

File:

• trunk/src/wp-includes/html-api/class-wp-html-processor.php (modified) (1 diff)

trunk/src/wp-includes/html-api/class-wp-html-processor.php

@@ -549 +549 @@
             $this->bookmark_tag(),
             $this->get_tag(),
-            $this->is_tag_closer(),
+            $this->has_self_closing_flag(),
             $this->release_internal_bookmark_on_destruct
         );