Changeset 57586

Timestamp:

02/12/2024 09:35:40 AM (10 months ago)

Author:

swissspidy

Message:

Plugins: Store plugin deletion results in temporary option.

Storing the data in a non-autoloaded rather than a transient ensures it cannot be accidentally removed due to a cache flush.

Props: kkmuffme, mukesh27.
Fixes #59433.

File:

• trunk/src/wp-admin/plugins.php (modified) (2 diffs)

trunk/src/wp-admin/plugins.php

@@ -428 +428 @@
             $delete_result = delete_plugins( $plugins );
 
-            // Store the result in a cache rather than a URL param due to object type & length.
-            set_transient( 'plugins_delete_result_' . $user_ID, $delete_result );
+            // Store the result in an option rather than a URL param due to object type & length.
+            // Cannot use transient/cache, as that could get flushed if any plugin flushes data on uninstall/delete.
+            update_option( 'plugins_delete_result_' . $user_ID, $delete_result, false );
             wp_redirect( self_admin_url( "plugins.php?deleted=$plugins_to_delete&plugin_status=$status&paged=$page&s=$s" ) );
             exit;
@@ -691 +692 @@
 
 } elseif ( isset( $_GET['deleted'] ) ) {
-    $delete_result = get_transient( 'plugins_delete_result_' . $user_ID );
+    $delete_result = get_option( 'plugins_delete_result_' . $user_ID );
     // Delete it once we're done.
-    delete_transient( 'plugins_delete_result_' . $user_ID );
+    delete_option( 'plugins_delete_result_' . $user_ID );
 
     if ( is_wp_error( $delete_result ) ) {