Changeset 57597 for trunk/src/wp-includes/media.php

Timestamp:

02/12/2024 04:06:47 PM (15 months ago)

Author:

swissspidy

Message:

Shortcodes: Always return an array in shortcode_parse_atts().

Previously, shortcode_parse_atts() would return the input (an empty string) if a shortcode had no attributes, even though the documentation said otherwise.

Always returning an (empty) array reduces confusion and improves developer experience as the return value does not have to be manually checked in the shortcode itself.

Props: nicolefurlan, swissspidy, johnbillion, bedas.
Fixes #59249.

File:

• trunk/src/wp-includes/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -2355 +2355 @@
  */
 function img_caption_shortcode( $attr, $content = '' ) {
-    if ( ! $attr ) {
-        $attr = array();
-    }
-
     // New-style shortcode with the caption inside the shortcode with the link and image tags.
     if ( ! isset( $attr['caption'] ) ) {