Changeset 57599

Timestamp:

02/12/2024 06:50:47 PM (10 months ago)

Author:

SergeyBiryukov

Message:

Twenty Nineteen: Correct line height for Button block.

This commit moves line-height to the Buttons container and removes the duplicate outline property.

Props sabernhardt, nidhidhandhukiya, monzuralam, shailu25, hrrarya, karmatosed, harshgajipara, nicolefurlan, fnpen, oglekler, poena, huzaifaalmesbah, audrasjb.
Fixes #58443.

Location:

trunk/src/wp-content/themes/twentynineteen

Files:

• sass/blocks/_blocks.scss (modified) (2 diffs)
• style-editor.css (modified) (1 diff)
• style-editor.scss (modified) (1 diff)
• style-rtl.css (modified) (2 diffs)
• style.css (modified) (3 diffs)

trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss

@@ -164 +164 @@
     }
 
-    //! Button
+    //! Buttons
+    .wp-block-buttons {
+        line-height: $font__line-height-heading;
+    }
+
     .wp-block-button {
 
@@ -172 +176 @@
             font-size: $font__size-sm;
             @include font-family( $font__heading );
-            line-height: $font__line-height-heading;
             box-sizing: border-box;
             font-weight: bold;
             text-decoration: none;
             padding: ($size__spacing-unit * .76) $size__spacing-unit;
-            outline: none;
             outline: none;
 

trunk/src/wp-content/themes/twentynineteen/style-editor.css

@@ -1005 +1005 @@
 
 /** === Button === */
+.wp-block-buttons {
+  line-height: 1.2;
+}
+
 .wp-block-button .wp-block-button__link {
-  line-height: inherit;
   font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
   font-size: 0.88889em;

trunk/src/wp-content/themes/twentynineteen/style-editor.scss

@@ -380 +380 @@
 /** === Button === */
 
+.wp-block-buttons {
+    line-height: $font__line-height-heading;
+}
+
 .wp-block-button {
 
     .wp-block-button__link {
-        line-height:inherit;
         @include font-family( $font__heading );
         font-size: $font__size-sm;

trunk/src/wp-content/themes/twentynineteen/style-rtl.css

@@ -5485 +5485 @@
 }
 
+.entry .entry-content .wp-block-buttons {
+  line-height: 1.2;
+}
+
 .entry .entry-content .wp-block-button .wp-block-button__link {
   transition: background 150ms ease-in-out;
@@ -5490 +5494 @@
   font-size: 0.88889em;
   font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
-  line-height: 1.2;
   box-sizing: border-box;
   font-weight: bold;
   text-decoration: none;
   padding: 0.76rem 1rem;
-  outline: none;
   outline: none;
 }

trunk/src/wp-content/themes/twentynineteen/style.css

@@ -2805 +2805 @@
   color: inherit;
   cursor: pointer;
-  transition: background 250ms ease-in-out, transform 150ms ease;
+  transition: background 250ms ease-in-out,
+ transform 150ms ease;
   -webkit-appearance: none;
   -moz-appearance: none;
@@ -5497 +5498 @@
 }
 
+.entry .entry-content .wp-block-buttons {
+  line-height: 1.2;
+}
+
 .entry .entry-content .wp-block-button .wp-block-button__link {
   transition: background 150ms ease-in-out;
@@ -5502 +5507 @@
   font-size: 0.88889em;
   font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
-  line-height: 1.2;
   box-sizing: border-box;
   font-weight: bold;
   text-decoration: none;
   padding: 0.76rem 1rem;
-  outline: none;
   outline: none;
 }