Make WordPress Core

Changeset 57599


Ignore:
Timestamp:
02/12/2024 06:50:47 PM (10 months ago)
Author:
SergeyBiryukov
Message:

Twenty Nineteen: Correct line height for Button block.

This commit moves line-height to the Buttons container and removes the duplicate outline property.

Props sabernhardt, nidhidhandhukiya, monzuralam, shailu25, hrrarya, karmatosed, harshgajipara, nicolefurlan, fnpen, oglekler, poena, huzaifaalmesbah, audrasjb.
Fixes #58443.

Location:
trunk/src/wp-content/themes/twentynineteen
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss

    r54413 r57599  
    164164    }
    165165
    166     //! Button
     166    //! Buttons
     167    .wp-block-buttons {
     168        line-height: $font__line-height-heading;
     169    }
     170
    167171    .wp-block-button {
    168172
     
    172176            font-size: $font__size-sm;
    173177            @include font-family( $font__heading );
    174             line-height: $font__line-height-heading;
    175178            box-sizing: border-box;
    176179            font-weight: bold;
    177180            text-decoration: none;
    178181            padding: ($size__spacing-unit * .76) $size__spacing-unit;
    179             outline: none;
    180182            outline: none;
    181183
  • trunk/src/wp-content/themes/twentynineteen/style-editor.css

    r57579 r57599  
    10051005
    10061006/** === Button === */
     1007.wp-block-buttons {
     1008  line-height: 1.2;
     1009}
     1010
    10071011.wp-block-button .wp-block-button__link {
    1008   line-height: inherit;
    10091012  font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
    10101013  font-size: 0.88889em;
  • trunk/src/wp-content/themes/twentynineteen/style-editor.scss

    r57579 r57599  
    380380/** === Button === */
    381381
     382.wp-block-buttons {
     383    line-height: $font__line-height-heading;
     384}
     385
    382386.wp-block-button {
    383387
    384388    .wp-block-button__link {
    385         line-height:inherit;
    386389        @include font-family( $font__heading );
    387390        font-size: $font__size-sm;
  • trunk/src/wp-content/themes/twentynineteen/style-rtl.css

    r57069 r57599  
    54855485}
    54865486
     5487.entry .entry-content .wp-block-buttons {
     5488  line-height: 1.2;
     5489}
     5490
    54875491.entry .entry-content .wp-block-button .wp-block-button__link {
    54885492  transition: background 150ms ease-in-out;
     
    54905494  font-size: 0.88889em;
    54915495  font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
    5492   line-height: 1.2;
    54935496  box-sizing: border-box;
    54945497  font-weight: bold;
    54955498  text-decoration: none;
    54965499  padding: 0.76rem 1rem;
    5497   outline: none;
    54985500  outline: none;
    54995501}
  • trunk/src/wp-content/themes/twentynineteen/style.css

    r57069 r57599  
    28052805  color: inherit;
    28062806  cursor: pointer;
    2807   transition: background 250ms ease-in-out, transform 150ms ease;
     2807  transition: background 250ms ease-in-out,
     2808 transform 150ms ease;
    28082809  -webkit-appearance: none;
    28092810  -moz-appearance: none;
     
    54975498}
    54985499
     5500.entry .entry-content .wp-block-buttons {
     5501  line-height: 1.2;
     5502}
     5503
    54995504.entry .entry-content .wp-block-button .wp-block-button__link {
    55005505  transition: background 150ms ease-in-out;
     
    55025507  font-size: 0.88889em;
    55035508  font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
    5504   line-height: 1.2;
    55055509  box-sizing: border-box;
    55065510  font-weight: bold;
    55075511  text-decoration: none;
    55085512  padding: 0.76rem 1rem;
    5509   outline: none;
    55105513  outline: none;
    55115514}
Note: See TracChangeset for help on using the changeset viewer.