Changeset 57615

Timestamp:

02/13/2024 12:05:00 PM (13 months ago)

Author:

costdev

Message:

Plugins: Only set card button status on plugin install pages.

Previously, the setCardButtonStatus() JS function was called when a card had the ID 'plugin-information-footer'. However, the card will only exist on plugin install pages. This caused a failure when updating plugins from the plugin row on plugins.php due to an undefined $card variable.

This adds a guard to ensure that the current page is one of the plugin install pages, preventing the error and allowing plugin updates from the plugins.php rows to work as expected.

Follow-up to [57545].

Props Presskopp, huzaifaalmesbah, krupajnanda, hellofromTonya, krupalpanchal, costdev.
Fixes #60521.

File:

• trunk/src/js/_enqueues/wp/updates.js (modified) (3 diffs)

trunk/src/js/_enqueues/wp/updates.js

@@ -479 +479 @@
         var $updateRow, $card, $message, message,
             $adminBarUpdates = $( '#wp-admin-bar-updates' ),
-            buttonText = __( 'Updating...' );
+            buttonText = __( 'Updating...' ),
+            isPluginInstall = 'plugin-install' === pagenow || 'plugin-install-network' === pagenow;
 
         args = _.extend( {
@@ -494 +495 @@
                 $updateRow.find( '.plugin-title strong' ).text()
             );
-        } else if ( 'plugin-install' === pagenow || 'plugin-install-network' === pagenow ) {
+        } else if ( isPluginInstall ) {
             $card    = $( '.plugin-card-' + args.slug + ', #plugin-information-footer' );
             $message = $card.find( '.update-now' ).addClass( 'updating-message' );
@@ -519 +520 @@
         $document.trigger( 'wp-plugin-updating', args );
 
-        if ( 'plugin-information-footer' === $card.attr('id' ) ) {
+        if ( isPluginInstall && 'plugin-information-footer' === $card.attr( 'id' ) ) {
             wp.updates.setCardButtonStatus(
                 {