Make WordPress Core


Ignore:
Timestamp:
02/13/2024 01:07:29 PM (4 months ago)
Author:
SergeyBiryukov
Message:

General: Some minor adjustments for the Site Icon option:

  • Improve buttons flow on small viewports, taking longer translations into account.
  • Make alt attributes translatable.
  • Remove unused id attributes.

Follow-up to [57602].

Props kebbet, afercia, mukesh27.
See #54370.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/options-general.php

    r57602 r57618  
    126126            <img src="<?php echo esc_url( admin_url( 'images/' . ( is_rtl() ? 'browser-rtl.png' : 'browser.png' ) ) ); ?>" class="browser-preview" width="182" alt="">
    127127            <div class="favicon">
    128                 <img src="<?php site_icon_url(); ?>" alt="Preview as a browser icon">
     128                <img src="<?php site_icon_url(); ?>" alt="<?php esc_attr_e( 'Preview as a browser icon' ); ?>">
    129129            </div>
    130130            <span class="browser-title" aria-hidden="true"><?php echo get_bloginfo( 'name' ); ?></span>
    131131        </div>
    132         <img class="app-icon-preview" src="<?php site_icon_url(); ?>" alt="Preview as an app icon">
     132        <img class="app-icon-preview" src="<?php site_icon_url(); ?>" alt="<?php esc_attr_e( 'Preview as an app icon' ); ?>">
    133133    </div>
    134134    <input type="hidden" name="site_icon" id="site_icon_hidden_field" value="<?php form_option( 'site_icon' ); ?>" />
    135     <p>
     135    <div class="action-buttons">
    136136        <button type="button"
    137137            id="choose-from-library-link"
     
    159159            <?php _e( 'Remove Site Icon' ); ?>
    160160        </button>
    161     </p>
    162 
    163     <p class="description" id="site-icon-description">
     161    </div>
     162
     163    <p class="description">
    164164        <?php _e( 'Site Icons are what you see in browser tabs, bookmark bars, and within the WordPress mobile apps. Upload one here!' ); ?>
    165165    </p>
    166     <p class="description" id="site-icon-further-description">
     166    <p class="description">
    167167        <?php
    168168            /* translators: %s: Site Icon size in pixels. */
Note: See TracChangeset for help on using the changeset viewer.