Changeset 57627 for trunk/tests/phpunit/tests/block-templates/buildBlockTemplateResultFromPost.php

Timestamp:

02/13/2024 03:10:21 PM (11 months ago)

Author:

Bernhard Reiter

Message:

Block Hooks: Set ignoredHookedBlocks metadata upon saving.

Decouple hooked blocks insertion from setting the metadata.ignoredHookedBlocks attribute on anchor blocks, and perform the latter step upon saving a template or template part to the database. This ensures that anchor blocks that have been newly added to a template (or part) on the client side will also get ignoredHookedBlocks metadata set correctly, thus preserving editor/front-end parity. Hooked block insertion, on the other hand, will continue to happen upon reading a template (or part).

Props gziolo, tomjcafferkey.
Fixes #60506.

File:

• trunk/tests/phpunit/tests/block-templates/buildBlockTemplateResultFromPost.php (modified) (4 diffs)

trunk/tests/phpunit/tests/block-templates/buildBlockTemplateResultFromPost.php

@@ -19 +19 @@
         if ( $registry->is_registered( 'tests/my-block' ) ) {
             $registry->unregister( 'tests/my-block' );
+        }
+
+        if ( $registry->is_registered( 'tests/ignored' ) ) {
+            $registry->unregister( 'tests/ignored' );
         }
 
@@ -68 +72 @@
     /**
      * @ticket 59646
+     * @ticket 60506
      */
     public function test_should_inject_hooked_block_into_template() {
@@ -84 +89 @@
         );
         $this->assertStringStartsWith( '<!-- wp:tests/my-block /-->', $template->content );
-        $this->assertStringContainsString( '"metadata":{"ignoredHookedBlocks":["tests/my-block"]}', $template->content );
     }
 
     /**
      * @ticket 59646
+     * @ticket 60506
      */
     public function test_should_inject_hooked_block_into_template_part() {
@@ -105 +110 @@
         );
         $this->assertStringEndsWith( '<!-- wp:tests/my-block /-->', $template_part->content );
-        $this->assertStringContainsString( '"metadata":{"ignoredHookedBlocks":["tests/my-block"]}', $template_part->content );
+    }
+
+    /**
+     * @ticket 59646
+     * @ticket 60506
+     */
+    public function test_should_not_inject_ignored_hooked_block_into_template() {
+        register_block_type(
+            'tests/ignored',
+            array(
+                'block_hooks' => array(
+                    'core/heading' => 'after',
+                ),
+            )
+        );
+
+        $template = _build_block_template_result_from_post(
+            self::$template_post,
+            'wp_template'
+        );
+        $this->assertStringNotContainsString( '<!-- wp:tests/ignored /-->', $template->content );
+    }
+
+    /**
+     * @ticket 59646
+     * @ticket 60506
+     */
+    public function test_should_not_inject_ignored_hooked_block_into_template_part() {
+        register_block_type(
+            'tests/ignored',
+            array(
+                'block_hooks' => array(
+                    'core/heading' => 'after',
+                ),
+            )
+        );
+
+        $template_part = _build_block_template_result_from_post(
+            self::$template_part_post,
+            'wp_template_part'
+        );
+        $this->assertStringNotContainsString( '<!-- wp:tests/ignored /-->', $template_part->content );
     }
 }