Changeset 57633

Timestamp:

02/14/2024 07:25:56 PM (13 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Allow $newlineEscape parameter in WP_Text_Diff_Renderer_inline::_splitOnWords().

This resolves a WPCS warning:

Variable "$newlineEscape" is not in valid snake_case format, try "$newline_escape"

The WP_Text_Diff_Renderer_inline class extends the Text_Diff_Renderer_inline class from the Text_Diff package and should have the same parameters as the parent class method, per the Task 1 section of ticket #51553.

Follow-up to [7747], [55163].

See #59650.

File:

• trunk/src/wp-includes/class-wp-text-diff-renderer-inline.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-text-diff-renderer-inline.php

@@ -25 +25 @@
      * @return string
      */
-    public function _splitOnWords( $string, $newlineEscape = "\n" ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.stringFound
+    public function _splitOnWords( $string, $newlineEscape = "\n" ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.stringFound,WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase
         $string = str_replace( "\0", '', $string );
         $words  = preg_split( '/([^\w])/u', $string, -1, PREG_SPLIT_DELIM_CAPTURE );
-        $words  = str_replace( "\n", $newlineEscape, $words );
+        $words  = str_replace( "\n", $newlineEscape, $words ); // phpcs:ignore WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase
         return $words;
     }