Changeset 57641 for trunk/src/wp-includes/class-wp-block.php

Timestamp:

02/16/2024 12:53:16 PM (2 years ago)

Author:

gziolo

Message:

Editor: Merge uses_context defined by block bindings sources with block types

Adds logic that fixes the limitation for souces by allowing merging the uses_context defined by block bindings sources into supported block types. Each source defines the context it needs and it is added to the block types that are using the block bindings API.

Fixes #60525.
Props santosguillamot, gziolo, czapla, thekt12.

File:

• trunk/src/wp-includes/class-wp-block.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-block.php

@@ -232 +232 @@
      */
     private function process_block_bindings() {
-        $parsed_block = $this->parsed_block;
-
-        $computed_attributes = array();
-
-        // Allowed blocks that support block bindings.
-        // TODO: Look for a mechanism to opt-in for this. Maybe adding a property to block attributes?
-        $allowed_blocks = array(
+        $parsed_block               = $this->parsed_block;
+        $computed_attributes        = array();
+        $supported_block_attributes = array(
             'core/paragraph' => array( 'content' ),
             'core/heading'   => array( 'content' ),
@@ -245 +241 @@
         );
 
-        // If the block doesn't have the bindings property, isn't one of the allowed
+        // If the block doesn't have the bindings property, isn't one of the supported
         // block types, or the bindings property is not an array, return the block content.
         if (
-            ! isset( $allowed_blocks[ $this->name ] ) ||
+            ! isset( $supported_block_attributes[ $this->name ] ) ||
             empty( $parsed_block['attrs']['metadata']['bindings'] ) ||
             ! is_array( $parsed_block['attrs']['metadata']['bindings'] )
@@ -256 +252 @@
 
         foreach ( $parsed_block['attrs']['metadata']['bindings'] as $attribute_name => $block_binding ) {
-            // If the attribute is not in the allowed list, process next attribute.
-            if ( ! in_array( $attribute_name, $allowed_blocks[ $this->name ], true ) ) {
+            // If the attribute is not in the supported list, process next attribute.
+            if ( ! in_array( $attribute_name, $supported_block_attributes[ $this->name ], true ) ) {
                 continue;
             }