Changeset 57641 for trunk/tests/phpunit/tests/block-bindings/wpBlockBindingsRegistry.php

Timestamp:

02/16/2024 12:53:16 PM (2 years ago)

Author:

gziolo

Message:

Editor: Merge uses_context defined by block bindings sources with block types

Adds logic that fixes the limitation for souces by allowing merging the uses_context defined by block bindings sources into supported block types. Each source defines the context it needs and it is added to the block types that are using the block bindings API.

Fixes #60525.
Props santosguillamot, gziolo, czapla, thekt12.

File:

• trunk/tests/phpunit/tests/block-bindings/wpBlockBindingsRegistry.php (modified) (4 diffs)

trunk/tests/phpunit/tests/block-bindings/wpBlockBindingsRegistry.php

@@ -40 +40 @@
                 return 'test-value';
             },
+            'uses_context'       => array( 'sourceContext' ),
         );
     }
@@ -158 +159 @@
 
         self::$test_source_properties['get_value_callback'] = 'not-a-callback';
+
+        $result = $this->registry->register( self::$test_source_name, self::$test_source_properties );
+        $this->assertFalse( $result );
+    }
+
+    /**
+     * Should reject block bindings registration if `uses_context` is not an array.
+     *
+     * @ticket 60525
+     *
+     * @covers WP_Block_Bindings_Registry::register
+     *
+     * @expectedIncorrectUsage WP_Block_Bindings_Registry::register
+     */
+    public function test_register_invalid_string_uses_context() {
+
+        self::$test_source_properties['uses_context'] = 'not-an-array';
 
         $result = $this->registry->register( self::$test_source_name, self::$test_source_properties );
@@ -180 +198 @@
             $result
         );
+        $this->assertSame( 'test/source', $result->name );
+        $this->assertSame( 'Test source', $result->label );
+        $this->assertSame(
+            'test-value',
+            $result->get_value( array(), null, '' )
+        );
+        $this->assertEquals( array( 'sourceContext' ), $result->uses_context );
     }
 
@@ -322 +347 @@
         $this->assertTrue( $result );
     }
+
+    /**
+     * Tests merging `uses_context` from multiple sources.
+     *
+     * @ticket 60525
+     *
+     * @covers ::register_block_bindings_source
+     * @covers WP_Block_Type::get_uses_context
+     */
+    public function test_merging_uses_context_from_multiple_sources() {
+        $get_value_callback = function () {
+            return 'Anything';
+        };
+
+        $block_registry        = WP_Block_Type_Registry::get_instance();
+        $original_uses_context = $block_registry->get_registered( 'core/paragraph' )->uses_context;
+
+        register_block_bindings_source(
+            'test/source-one',
+            array(
+                'label'              => 'Test Source One',
+                'get_value_callback' => $get_value_callback,
+                'uses_context'       => array( 'commonContext', 'sourceOneContext' ),
+            )
+        );
+
+        register_block_bindings_source(
+            'test/source-two',
+            array(
+                'label'              => 'Test Source Two',
+                'get_value_callback' => $get_value_callback,
+                'uses_context'       => array( 'commonContext', 'sourceTwoContext' ),
+            )
+        );
+
+        $new_uses_context = $block_registry->get_registered( 'core/paragraph' )->uses_context;
+        // Checks that the resulting `uses_context` contains the values from both sources.
+        $this->assertContains( 'commonContext', $new_uses_context );
+        $this->assertContains( 'sourceOneContext', $new_uses_context );
+        $this->assertContains( 'sourceTwoContext', $new_uses_context );
+        // Checks that the resulting `uses_context` added 3 unique items.
+        $this->assertSame( count( $original_uses_context ) + 3, count( $new_uses_context ) );
+        // Checks that the array isn't sparse to prevent issues in the editor.
+        $this->assertSame( array_key_last( $new_uses_context ), count( $new_uses_context ) - 1 );
+    }
 }