Make WordPress Core


Ignore:
Timestamp:
02/17/2024 03:22:37 PM (14 months ago)
Author:
swissspidy
Message:

General: Consistently cast return value to int in functions that use ceil().

The return value of ceil() is still of type float as the value range of float is usually bigger than that of int.

Props crstauf, audrasjb.
Fixes #58683.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

    r56415 r57648  
    349349        // Store pagination values for headers.
    350350        $per_page = (int) $prepared_args['number'];
    351         $page     = ceil( ( ( (int) $prepared_args['offset'] ) / $per_page ) + 1 );
     351        $page     = (int) ceil( ( ( (int) $prepared_args['offset'] ) / $per_page ) + 1 );
    352352
    353353        $response->header( 'X-WP-Total', (int) $total_terms );
    354354
    355         $max_pages = ceil( $total_terms / $per_page );
    356 
    357         $response->header( 'X-WP-TotalPages', (int) $max_pages );
     355        $max_pages = (int) ceil( $total_terms / $per_page );
     356
     357        $response->header( 'X-WP-TotalPages', $max_pages );
    358358
    359359        $request_params = $request->get_query_params();
Note: See TracChangeset for help on using the changeset viewer.