Make WordPress Core


Ignore:
Timestamp:
02/17/2024 03:22:37 PM (12 months ago)
Author:
swissspidy
Message:

General: Consistently cast return value to int in functions that use ceil().

The return value of ceil() is still of type float as the value range of float is usually bigger than that of int.

Props crstauf, audrasjb.
Fixes #58683.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php

    r56833 r57648  
    349349        // Store pagination values for headers then unset for count query.
    350350        $per_page = (int) $prepared_args['number'];
    351         $page     = ceil( ( ( (int) $prepared_args['offset'] ) / $per_page ) + 1 );
     351        $page     = (int) ceil( ( ( (int) $prepared_args['offset'] ) / $per_page ) + 1 );
    352352
    353353        $prepared_args['fields'] = 'ID';
     
    364364        $response->header( 'X-WP-Total', (int) $total_users );
    365365
    366         $max_pages = ceil( $total_users / $per_page );
    367 
    368         $response->header( 'X-WP-TotalPages', (int) $max_pages );
     366        $max_pages = (int) ceil( $total_users / $per_page );
     367
     368        $response->header( 'X-WP-TotalPages', $max_pages );
    369369
    370370        $base = add_query_arg( urlencode_deep( $request->get_query_params() ), rest_url( sprintf( '%s/%s', $this->namespace, $this->rest_base ) ) );
Note: See TracChangeset for help on using the changeset viewer.