Changeset 57650

Timestamp:

02/17/2024 04:32:37 PM (10 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in get_comment_pages_count() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [27055], [48937], [54402], [57244], [57648].

Props costdev.
See #58683, #59655.

File:

• trunk/tests/phpunit/tests/comment/getCommentsPagesCount.php (modified) (5 diffs)

trunk/tests/phpunit/tests/comment/getCommentsPagesCount.php

@@ -79 +79 @@
         $comments = get_comments( array( 'post_id' => $post->ID ) );
 
-        $this->assertEquals( 3, get_comment_pages_count( $comments, 10, false ) );
-        $this->assertEquals( 2, get_comment_pages_count( $comments, 10, true ) );
-        $this->assertEquals( 4, get_comment_pages_count( $comments, 4, true ) );
+        $this->assertSame( 3, get_comment_pages_count( $comments, 10, false ) );
+        $this->assertSame( 2, get_comment_pages_count( $comments, 10, true ) );
+        $this->assertSame( 4, get_comment_pages_count( $comments, 4, true ) );
     }
 
@@ -102 +102 @@
         update_option( 'thread_comments', false );
 
-        $this->assertEquals( 3, get_comment_pages_count( $comments, 10, false ) );
-        $this->assertEquals( 2, get_comment_pages_count( $comments, 10, true ) );
-        $this->assertEquals( 3, get_comment_pages_count( $comments, 10, null ) );
-        $this->assertEquals( 3, get_comment_pages_count( $comments, 10 ) );
+        $this->assertSame( 3, get_comment_pages_count( $comments, 10, false ) );
+        $this->assertSame( 2, get_comment_pages_count( $comments, 10, true ) );
+        $this->assertSame( 3, get_comment_pages_count( $comments, 10, null ) );
+        $this->assertSame( 3, get_comment_pages_count( $comments, 10 ) );
 
         update_option( 'thread_comments', true );
 
-        $this->assertEquals( 3, get_comment_pages_count( $comments, 10, false ) );
-        $this->assertEquals( 2, get_comment_pages_count( $comments, 10, true ) );
-        $this->assertEquals( 2, get_comment_pages_count( $comments, 10, null ) );
-        $this->assertEquals( 2, get_comment_pages_count( $comments, 10 ) );
+        $this->assertSame( 3, get_comment_pages_count( $comments, 10, false ) );
+        $this->assertSame( 2, get_comment_pages_count( $comments, 10, true ) );
+        $this->assertSame( 2, get_comment_pages_count( $comments, 10, null ) );
+        $this->assertSame( 2, get_comment_pages_count( $comments, 10 ) );
     }
 
@@ -141 +141 @@
         update_option( 'comments_per_page', 25 );
 
-        $this->assertEquals( 3, get_comment_pages_count() );
-        $this->assertEquals( 2, get_comment_pages_count( null, 20 ) );
+        $this->assertSame( 3, get_comment_pages_count() );
+        $this->assertSame( 2, get_comment_pages_count( null, 20 ) );
 
         $wp_query = new WP_Query(
@@ -152 +152 @@
         );
 
-        $this->assertEquals( 1, get_comment_pages_count() );
-        $this->assertEquals( 5, get_comment_pages_count( null, 5 ) );
+        $this->assertSame( 1, get_comment_pages_count() );
+        $this->assertSame( 5, get_comment_pages_count( null, 5 ) );
 
         $wp_query->query_vars['comments_per_page'] = null;
@@ -159 +159 @@
         update_option( 'comments_per_page', 5 );
 
-        $this->assertEquals( 5, get_comment_pages_count() );
-        $this->assertEquals( 3, get_comment_pages_count( null, 11 ) );
-        $this->assertEquals( 5, get_comment_pages_count( null, 0 ) );
+        $this->assertSame( 5, get_comment_pages_count() );
+        $this->assertSame( 3, get_comment_pages_count( null, 11 ) );
+        $this->assertSame( 5, get_comment_pages_count( null, 0 ) );
     }