Changeset 57653 for trunk/tests/phpunit/tests/comment/query.php

Timestamp:

02/18/2024 06:59:24 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in WP_Query tests involving ::$max_num_pages property.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [48937], [54402], [54768], [57648].

Props costdev.
See #58683, #59655.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (2 diffs)

trunk/tests/phpunit/tests/comment/query.php

@@ -3989 +3989 @@
 
         $this->assertSame( 3, $q->found_comments );
-        $this->assertEquals( 2, $q->max_num_pages );
+        $this->assertSame( 2, $q->max_num_pages );
     }
 
@@ -4018 +4018 @@
 
         $this->assertSame( 3, $q->found_comments );
-        $this->assertEquals( 2, $q->max_num_pages );
+        $this->assertSame( 2, $q->max_num_pages );
     }