Changeset 57657 for trunk/tests/phpunit/tests/fonts/font-library/wpFontUtils/sanitizeFontFamily.php

Timestamp:

02/20/2024 07:09:43 AM (10 months ago)

Author:

youknowriad

Message:

Editor: Format and sanitize font family names according the CSS spec.

This fixes two bugs in the font library.

• Fonts using special characters were not being rendered properly in the frontend.
• Allows the ability to use generic() in font family names.

Props mmaattiiaass, nithins53, kafleg, vivekawsm, swissspidy, audrasjb.
Fixes #60537.

File:

• trunk/tests/phpunit/tests/fonts/font-library/wpFontUtils/sanitizeFontFamily.php (modified) (2 diffs)

trunk/tests/phpunit/tests/fonts/font-library/wpFontUtils/sanitizeFontFamily.php

@@ -36 +36 @@
         return array(
             'data_families_with_spaces_and_numbers' => array(
-                'font_family' => 'Rock 3D , Open Sans,serif',
-                'expected'    => '"Rock 3D", "Open Sans", serif',
+                'font_family' => 'Arial, Rock 3D , Open Sans,serif',
+                'expected'    => 'Arial, "Rock 3D", "Open Sans", serif',
             ),
             'data_single_font_family'               => array(
                 'font_family' => 'Rock 3D',
                 'expected'    => '"Rock 3D"',
-            ),
-            'data_no_spaces'                        => array(
-                'font_family' => 'Rock3D',
-                'expected'    => 'Rock3D',
             ),
             'data_many_spaces_and_existing_quotes'  => array(
@@ -59 +55 @@
                 'expected'    => '"Rock 3D"',
             ),
+            'data_font_family_with_generic_names'   => array(
+                'font_family' => 'generic(kai), generic(font[name]), generic(fangsong), Rock 3D',
+                'expected'    => 'generic(kai), "generic(font[name])", generic(fangsong), "Rock 3D"',
+            ),
         );
     }