Changeset 57658 for trunk/src/wp-admin/includes/class-plugin-upgrader.php

Timestamp:

02/20/2024 07:25:38 AM (16 months ago)

Author:

costdev

Message:

Plugin Dependencies: Remove auto-deactivation and bootstrapping logic.

Automatic deactivation of dependents with unmet dependencies requires a write operation to the database. This was performed during Core's bootstrap, which risked the database and cache becoming out-of-sync on sites with heavy traffic.

No longer loading plugins that have unmet requirements has not had a final approach decided core-wide, and is still in discussion in #60491 to be handled in a future release.

The plugin_data option, used to persistently store plugin data for detecting unmet dependencies during Core's bootstrap, is no longer needed.

Follow-up to [57545], [57592], [57606], [57617].

Props dd32, azaozz, swissspidy, desrosj, afragen, pbiron, zunaid321, costdev.
Fixes #60457. See #60491, #60510, #60518.

File:

• trunk/src/wp-admin/includes/class-plugin-upgrader.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-plugin-upgrader.php

@@ -155 +155 @@
         // Force refresh of plugin update information.
         wp_clean_plugins_cache( $parsed_args['clear_update_cache'] );
-
-        $all_plugin_data = get_option( 'plugin_data', array() );
-        $plugin_file     = $this->new_plugin_data['file'];
-        unset( $this->new_plugin_data['file'] );
-        $all_plugin_data[ $plugin_file ] = $this->new_plugin_data;
-        update_option( 'plugin_data', $all_plugin_data );
 
         if ( $parsed_args['overwrite_package'] ) {
@@ -489 +483 @@
                 $info = get_plugin_data( $file, false, false );
                 if ( ! empty( $info['Name'] ) ) {
-                    $basename = basename( $file );
-                    $dirname  = basename( dirname( $file ) );
-
-                    if ( '.' === $dirname ) {
-                        $plugin_file = $basename;
-                    } else {
-                        $plugin_file = "$dirname/$basename";
-                    }
-                    $this->new_plugin_data         = ( $info );
-                    $this->new_plugin_data['file'] = $plugin_file;
+                    $this->new_plugin_data = $info;
                     break;
                 }