Changeset 57658 for trunk/src/wp-admin/includes/plugin.php

Timestamp:

02/20/2024 07:25:38 AM (2 years ago)

Author:

costdev

Message:

Plugin Dependencies: Remove auto-deactivation and bootstrapping logic.

Automatic deactivation of dependents with unmet dependencies requires a write operation to the database. This was performed during Core's bootstrap, which risked the database and cache becoming out-of-sync on sites with heavy traffic.

No longer loading plugins that have unmet requirements has not had a final approach decided core-wide, and is still in discussion in #60491 to be handled in a future release.

The plugin_data option, used to persistently store plugin data for detecting unmet dependencies during Core's bootstrap, is no longer needed.

Follow-up to [57545], [57592], [57606], [57617].

Props dd32, azaozz, swissspidy, desrosj, afragen, pbiron, zunaid321, costdev.
Fixes #60457. See #60491, #60510, #60518.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (7 diffs)

trunk/src/wp-admin/includes/plugin.php

@@ -334 +334 @@
         }
 
-        $new_plugin_data = array();
         foreach ( $plugin_files as $plugin_file ) {
                 if ( ! is_readable( "$plugin_root/$plugin_file" ) ) {
@@ -347 +346 @@
                 }
 
-                $new_plugin_file = str_replace(
-                        trailingslashit( WP_PLUGIN_DIR ),
-                        '',
-                        "$plugin_root/$plugin_file"
-                );
-
-                $new_plugin_data[ $new_plugin_file ]           = $plugin_data;
                 $wp_plugins[ plugin_basename( $plugin_file ) ] = $plugin_data;
         }
@@ -361 +353 @@
         $cache_plugins[ $plugin_folder ] = $wp_plugins;
         wp_cache_set( 'plugins', $cache_plugins, 'plugins' );
-
-        if ( ! wp_installing() ) {
-                update_option( 'plugin_data', $new_plugin_data );
-        }
 
         return $wp_plugins;
@@ -976 +964 @@
 
         $plugin_translations = wp_get_installed_translations( 'plugins' );
-        $all_plugin_data     = get_option( 'plugin_data', array() );
 
         $errors = array();
@@ -1021 +1008 @@
                         continue;
                 }
-                unset( $all_plugin_data[ $plugin_file ] );
 
                 $plugin_slug = dirname( $plugin_file );
@@ -1070 +1056 @@
                 return new WP_Error( 'could_not_remove_plugin', sprintf( $message, implode( ', ', $errors ) ) );
         }
-        update_option( 'plugin_data', $all_plugin_data );
 
         return true;
@@ -1215 +1200 @@
         }
 
+        WP_Plugin_Dependencies::initialize();
+
         if ( WP_Plugin_Dependencies::has_unmet_dependencies( $plugin ) ) {
                 $dependencies       = WP_Plugin_Dependencies::get_dependencies( $plugin );