Changeset 57658 for trunk/src/wp-includes/class-wp-plugin-dependencies.php

Timestamp:

02/20/2024 07:25:38 AM (2 years ago)

Author:

costdev

Message:

Plugin Dependencies: Remove auto-deactivation and bootstrapping logic.

Automatic deactivation of dependents with unmet dependencies requires a write operation to the database. This was performed during Core's bootstrap, which risked the database and cache becoming out-of-sync on sites with heavy traffic.

No longer loading plugins that have unmet requirements has not had a final approach decided core-wide, and is still in discussion in #60491 to be handled in a future release.

The plugin_data option, used to persistently store plugin data for detecting unmet dependencies during Core's bootstrap, is no longer needed.

Follow-up to [57545], [57592], [57606], [57617].

Props dd32, azaozz, swissspidy, desrosj, afragen, pbiron, zunaid321, costdev.
Fixes #60457. See #60491, #60510, #60518.

File:

• trunk/src/wp-includes/class-wp-plugin-dependencies.php (modified) (8 diffs)

trunk/src/wp-includes/class-wp-plugin-dependencies.php

@@ -106 +106 @@
 
         /**
-         * Initializes by fetching plugin header and plugin API data,
-         * and deactivating dependents with unmet dependencies.
+         * Whether Plugin Dependencies have been initialized.
+         *
+         * @since 6.5.0
+         *
+         * @var bool
+         */
+        protected static $initialized = false;
+
+        /**
+         * Initializes by fetching plugin header and plugin API data.
          *
          * @since 6.5.0
          */
         public static function initialize() {
-                self::read_dependencies_from_plugin_headers();
-                self::get_dependency_api_data();
-                self::deactivate_dependents_with_unmet_dependencies();
+                if ( false === self::$initialized ) {
+                        self::read_dependencies_from_plugin_headers();
+                        self::get_dependency_api_data();
+                        self::$initialized = true;
+                }
         }
 
@@ -126 +136 @@
          */
         public static function has_dependents( $plugin_file ) {
-                return in_array( self::convert_to_slug( $plugin_file ), self::$dependency_slugs, true );
+                return in_array( self::convert_to_slug( $plugin_file ), (array) self::$dependency_slugs, true );
         }
 
@@ -173 +183 @@
                 $dependents = array();
 
-                foreach ( self::$dependencies as $dependent => $dependencies ) {
+                foreach ( (array) self::$dependencies as $dependent => $dependencies ) {
                         if ( in_array( $slug, $dependencies, true ) ) {
                                 $dependents[] = $dependent;
@@ -370 +380 @@
 
         /**
-         * Displays an admin notice if dependencies have been deactivated.
-         *
-         * @since 6.5.0
-         */
-        public static function display_admin_notice_for_deactivated_dependents() {
-                /*
-                 * Plugin deactivated if dependencies not met.
-                 * Transient on a 10 second timeout.
-                 */
-                $deactivate_requires = get_site_transient( 'wp_plugin_dependencies_deactivated_plugins' );
-                if ( ! empty( $deactivate_requires ) ) {
-                        $deactivated_plugins = '';
-                        foreach ( $deactivate_requires as $deactivated ) {
-                                $deactivated_plugins .= '<li>' . esc_html( self::$plugins[ $deactivated ]['Name'] ) . '</li>';
-                        }
-                        wp_admin_notice(
-                                sprintf(
-                                        /* translators: 1: plugin names */
-                                        __( 'The following plugin(s) have been deactivated due to uninstalled or inactive dependencies: %s' ),
-                                        "<ul>$deactivated_plugins</ul>"
-                                ),
-                                array(
-                                        'type'        => 'error',
-                                        'dismissible' => true,
-                                )
-                        );
-                }
-        }
-
-        /**
          * Displays an admin notice if circular dependencies are installed.
          *
@@ -544 +524 @@
                 }
 
-                $all_plugin_data = get_option( 'plugin_data', array() );
-
-                if ( empty( $all_plugin_data ) ) {
-                        require_once ABSPATH . '/wp-admin/includes/plugin.php';
-                        $all_plugin_data = get_plugins();
-                }
-
-                self::$plugins = $all_plugin_data;
+                require_once ABSPATH . '/wp-admin/includes/plugin.php';
+                self::$plugins = get_plugins();
 
                 return self::$plugins;
@@ -622 +596 @@
 
         /**
-         * Gets plugin filepaths for active plugins that depend on the dependency.
-         *
-         * Recurses for each dependent that is also a dependency.
-         *
-         * @param string $plugin_file The dependency's filepath, relative to the plugin directory.
-         * @return string[] An array of active dependent plugin filepaths, relative to the plugin directory.
-         */
-        protected static function get_active_dependents_in_dependency_tree( $plugin_file ) {
-                $all_dependents = array();
-                $dependents     = self::get_dependents( self::convert_to_slug( $plugin_file ) );
-
-                if ( empty( $dependents ) ) {
-                        return $all_dependents;
-                }
-
-                require_once ABSPATH . '/wp-admin/includes/plugin.php';
-                foreach ( $dependents as $dependent ) {
-                        if ( is_plugin_active( $dependent ) ) {
-                                $all_dependents[] = $dependent;
-                                $all_dependents   = array_merge(
-                                        $all_dependents,
-                                        self::get_active_dependents_in_dependency_tree( $dependent )
-                                );
-                        }
-                }
-
-                return $all_dependents;
-        }
-
-        /**
-         * Deactivates dependent plugins with unmet dependencies.
-         *
-         * @since 6.5.0
-         */
-        protected static function deactivate_dependents_with_unmet_dependencies() {
-                $dependents_to_deactivate = array();
-                $circular_dependencies    = array_reduce(
-                        self::get_circular_dependencies(),
-                        function ( $all_circular, $circular_pair ) {
-                                return array_merge( $all_circular, $circular_pair );
-                        },
-                        array()
-                );
-
-                require_once ABSPATH . '/wp-admin/includes/plugin.php';
-                foreach ( self::$dependencies as $dependent => $dependencies ) {
-                        // Skip dependents that are no longer installed or aren't active.
-                        if ( ! array_key_exists( $dependent, self::$plugins ) || is_plugin_inactive( $dependent ) ) {
-                                continue;
-                        }
-
-                        // Skip plugins within a circular dependency tree or plugins that have no unmet dependencies.
-                        if ( in_array( $dependent, $circular_dependencies, true ) || ! self::has_unmet_dependencies( $dependent ) ) {
-                                continue;
-                        }
-
-                        $dependents_to_deactivate[] = $dependent;
-
-                        // Also add any plugins that rely on any of this plugin's dependents.
-                        $dependents_to_deactivate = array_merge(
-                                $dependents_to_deactivate,
-                                self::get_active_dependents_in_dependency_tree( $dependent )
-                        );
-                }
-
-                // Bail early if there are no dependents to deactivate.
-                if ( empty( $dependents_to_deactivate ) ) {
-                        return;
-                }
-
-                $dependents_to_deactivate = array_unique( $dependents_to_deactivate );
-
-                deactivate_plugins( $dependents_to_deactivate );
-                set_site_transient( 'wp_plugin_dependencies_deactivated_plugins', $dependents_to_deactivate, 10 );
-        }
-
-        /**
          * Gets the filepath of installed dependencies.
          * If a dependency is not installed, the filepath defaults to false.
@@ -709 +606 @@
                 if ( is_array( self::$dependency_filepaths ) ) {
                         return self::$dependency_filepaths;
+                }
+
+                if ( null === self::$dependency_slugs ) {
+                        return array();
                 }
 
@@ -847 +748 @@
                 }
 
+                if ( null === self::$dependencies ) {
+                        return array();
+                }
+
                 self::$circular_dependencies_slugs = array();