Changeset 57658 for trunk/tests/phpunit/tests/admin/plugin-dependencies/hasCircularDependency.php

Timestamp:

02/20/2024 07:25:38 AM (16 months ago)

Author:

costdev

Message:

Plugin Dependencies: Remove auto-deactivation and bootstrapping logic.

Automatic deactivation of dependents with unmet dependencies requires a write operation to the database. This was performed during Core's bootstrap, which risked the database and cache becoming out-of-sync on sites with heavy traffic.

No longer loading plugins that have unmet requirements has not had a final approach decided core-wide, and is still in discussion in #60491 to be handled in a future release.

The plugin_data option, used to persistently store plugin data for detecting unmet dependencies during Core's bootstrap, is no longer needed.

Follow-up to [57545], [57592], [57606], [57617].

Props dd32, azaozz, swissspidy, desrosj, afragen, pbiron, zunaid321, costdev.
Fixes #60457. See #60491, #60510, #60518.

File:

• trunk/tests/phpunit/tests/admin/plugin-dependencies/hasCircularDependency.php (modified) (1 diff)

trunk/tests/phpunit/tests/admin/plugin-dependencies/hasCircularDependency.php

@@ -17 +17 @@
  */
 class Tests_Admin_WPPluginDependencies_HasCircularDependency extends WP_PluginDependencies_UnitTestCase {
+
+    /**
+     * Tests that false is returned if Plugin Dependencies has not been initialized.
+     *
+     * @ticket 60457
+     */
+    public function test_should_return_false_before_initialization() {
+        $this->set_property_value(
+            'plugins',
+            array(
+                'dependent/dependent.php'   => array(
+                    'Name'            => 'Dependent',
+                    'RequiresPlugins' => 'dependency',
+                ),
+                'dependency/dependency.php' => array(
+                    'Name'            => 'Dependency',
+                    'RequiresPlugins' => 'dependent',
+                ),
+            )
+        );
+
+        // Ensure Plugin Dependencies has not been initialized.
+        $this->assertFalse(
+            $this->get_property_value( 'initialized' ),
+            'Plugin Dependencies has been initialized.'
+        );
+
+        $this->assertSame(
+            self::$static_properties['circular_dependencies_slugs'],
+            $this->get_property_value( 'circular_dependencies_slugs' ),
+            '"circular_dependencies_slugs" was not set to its default value.'
+        );
+
+        $this->assertFalse(
+            self::$instance->has_circular_dependency( 'dependency' ),
+            'false was not returned before initialization.'
+        );
+    }
 
     /**