Changeset 57664

Timestamp:

02/20/2024 11:20:22 AM (11 months ago)

Author:

youknowriad

Message:

Editor: Fix instance element styles for links applying to buttons.

These changes fix the selector used by block instance element styles for links so they do not get incorrectly applied to buttons.

Props aaronrobertshaw, freewebmentor, mukesh27.
Fixes #60557.

Location:

trunk

Files:

• src/wp-includes/block-supports/elements.php (modified) (1 diff)
• tests/phpunit/tests/block-supports/wpRenderElementsSupportStyles.php (modified) (2 diffs)

trunk/src/wp-includes/block-supports/elements.php

@@ -167 +167 @@
         ),
         'link'    => array(
-            'selector'       => ".$class_name a",
-            'hover_selector' => ".$class_name a:hover",
+            'selector'       => ".$class_name a:where(:not(.wp-element-button))",
+            'hover_selector' => ".$class_name a:where(:not(.wp-element-button)):hover",
             'skip'           => $skip_link_color_serialization,
         ),

trunk/tests/phpunit/tests/block-supports/wpRenderElementsSupportStyles.php

@@ -23 +23 @@
      *
      * @ticket 59555
+     * @ticket 60557
      *
      * @covers ::wp_render_elements_support_styles
@@ -140 +141 @@
                     ),
                 ),
-                'expected_styles' => '/^.wp-elements-[a-f0-9]{32} a' . $color_css_rules .
-                    '.wp-elements-[a-f0-9]{32} a:hover' . $color_css_rules . '$/',
+                'expected_styles' => '/^.wp-elements-[a-f0-9]{32} a:where\(:not\(.wp-element-button\)\)' . $color_css_rules .
+                    '.wp-elements-[a-f0-9]{32} a:where\(:not\(.wp-element-button\)\):hover' . $color_css_rules . '$/',
             ),
             'generic heading element styles are applied' => array(