Changeset 57680

Timestamp:

02/21/2024 05:33:54 PM (8 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in wp_insert_post() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [34085], [35183], [48937], [53782], [53785], [53883], [54402].

Props costdev.
See #59655.

File:

• trunk/tests/phpunit/tests/post/wpInsertPost.php (modified) (5 diffs)

trunk/tests/phpunit/tests/post/wpInsertPost.php

@@ -129 +129 @@
         $this->assertSame( $data['post_title'], $post->post_title );
         $this->assertSame( $data['post_status'], $post->post_status );
-        $this->assertEquals( $data['post_author'], $post->post_author );
+        $this->assertSame( (string) $data['post_author'], $post->post_author );
 
         // Test cache state.
@@ -676 +676 @@
 
         $post = get_post( $post_id );
-        $this->assertEquals( self::$user_ids['editor'], $post->post_author );
+        $this->assertSame( (string) self::$user_ids['editor'], $post->post_author );
         $this->assertSame( $title, $post->post_title );
     }
@@ -788 +788 @@
         $post_id = self::factory()->post->create( array( 'post_author' => 0 ) );
 
-        $this->assertEquals( 0, get_post( $post_id )->post_author );
+        $this->assertSame( '0', get_post( $post_id )->post_author );
     }
 
@@ -799 +799 @@
         $post_id = self::factory()->post->create( array( 'post_author' => null ) );
 
-        $this->assertEquals( self::$user_ids['editor'], get_post( $post_id )->post_author );
+        $this->assertSame( (string) self::$user_ids['editor'], get_post( $post_id )->post_author );
     }
 
@@ -917 +917 @@
         // Validate that the post has had the default category assigned again.
         $this->assertCount( 1, $assigned_terms );
-        $this->assertEquals( get_option( 'default_category' ), $assigned_terms[0]->term_id );
+        $this->assertSame( (int) get_option( 'default_category' ), $assigned_terms[0]->term_id );
     }