Changeset 57705

Timestamp:

02/24/2024 07:28:52 PM (16 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in comment_exists() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [34456], [34460].

Props costdev.
See #59655.

File:

• trunk/tests/phpunit/tests/admin/includesComment.php (modified) (5 diffs)

trunk/tests/phpunit/tests/admin/includesComment.php

@@ -53 +53 @@
     public function test_must_match_date_and_author() {
         $this->assertNull( comment_exists( 1, '2004-01-02 12:00:00' ) );
-        $this->assertEquals( self::$post_id, comment_exists( 1, '2014-05-06 12:00:00' ) );
+        $this->assertSame( (string) self::$post_id, comment_exists( 1, '2014-05-06 12:00:00' ) );
     }
 
@@ -62 +62 @@
      */
     public function test_default_value_of_timezone_should_be_blog() {
-        $this->assertEquals( self::$post_id, comment_exists( 1, '2014-05-06 12:00:00' ) );
+        $this->assertSame( (string) self::$post_id, comment_exists( 1, '2014-05-06 12:00:00' ) );
     }
 
@@ -71 +71 @@
      */
     public function test_should_respect_timezone_blog() {
-        $this->assertEquals( self::$post_id, comment_exists( 1, '2014-05-06 12:00:00', 'blog' ) );
+        $this->assertSame( (string) self::$post_id, comment_exists( 1, '2014-05-06 12:00:00', 'blog' ) );
     }
 
@@ -80 +80 @@
      */
     public function test_should_respect_timezone_gmt() {
-        $this->assertEquals( self::$post_id, comment_exists( 1, '2014-05-06 07:00:00', 'gmt' ) );
+        $this->assertSame( (string) self::$post_id, comment_exists( 1, '2014-05-06 07:00:00', 'gmt' ) );
     }
 
@@ -89 +89 @@
      */
     public function test_invalid_timezone_should_fall_back_on_blog() {
-        $this->assertEquals( self::$post_id, comment_exists( 1, '2014-05-06 12:00:00', 'not_a_valid_value' ) );
+        $this->assertSame( (string) self::$post_id, comment_exists( 1, '2014-05-06 12:00:00', 'not_a_valid_value' ) );
     }
 }