Changeset 57706

Timestamp:

02/25/2024 03:25:49 PM (7 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in new_admin_email_subject filter test.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [57283].

See #59655.

File:

• trunk/tests/phpunit/tests/admin/includesMisc.php (modified) (2 diffs)

trunk/tests/phpunit/tests/admin/includesMisc.php

@@ -33 +33 @@
      */
     public function test_new_admin_email_subject_filter() {
-        // Default value
+        // Default value.
         $mailer = tests_retrieve_phpmailer_instance();
         update_option_new_admin_email( 'old@example.com', 'new@example.com' );
-        $this->assertEquals( '[Test Blog] New Admin Email Address', $mailer->get_sent()->subject );
+        $this->assertSame( '[Test Blog] New Admin Email Address', $mailer->get_sent()->subject );
 
-        // Filtered value
+        // Filtered value.
         add_filter(
             'new_admin_email_subject',
@@ -52 +52 @@
         $mailer = tests_retrieve_phpmailer_instance();
         update_option_new_admin_email( 'old@example.com', 'new@example.com' );
-        $this->assertEquals( 'Filtered Admin Email Address', $mailer->get_sent()->subject );
+        $this->assertSame( 'Filtered Admin Email Address', $mailer->get_sent()->subject );
     }
 }