Changeset 57708 for trunk/src/wp-includes/admin-bar.php

Timestamp:

02/26/2024 12:50:22 AM (16 months ago)

Author:

joedolson

Message:

Toolbar: Accessibility: Keyboard navigation for screen readers.

Change the admin toolbar to have role="menu" and support opening for screen readers. Remove screen reader only log out link and collapse duplicate profile links into one link. This is an imperfect solution to a complex problem in the adminbar, but the lack of screen reader access to submenus is a major accessibility problem, and this fix provides access, even if the mechanism is imperfect.

Screen reader log out added in [21452].

Props abletec, Cheffheid, sabernhardt, alexstine, joedolson, afercia, sparklingrobots, danieltj, swissspidy, netweb, dionysous.
Fixes #34668, #43633.

File:

• trunk/src/wp-includes/admin-bar.php (modified) (6 diffs)

trunk/src/wp-includes/admin-bar.php

@@ -140 +140 @@
             '</span>',
         'href'  => $about_url,
+        'meta' => array(
+            'menu_title' => __( 'About WordPress' ),
+        ),
     );
 
@@ -283 +286 @@
             'href'   => $profile_url,
             'meta'   => array(
-                'class' => $class,
+                'class'      => $class,
+                'menu_title' => sprintf( __( 'Howdy, %s' ), $current_user->display_name ),
             ),
         )
@@ -326 +330 @@
     }
 
+    $user_info .= "<span class='edit-profile'>" . __( 'Edit Profile' ) . '</span>';
+
     $wp_admin_bar->add_node(
         array(
@@ -332 +338 @@
             'title'  => $user_info,
             'href'   => $profile_url,
-            'meta'   => array(
-                'tabindex' => -1,
-            ),
-        )
-    );
-
-    if ( false !== $profile_url ) {
-        $wp_admin_bar->add_node(
-            array(
-                'parent' => 'user-actions',
-                'id'     => 'edit-profile',
-                'title'  => __( 'Edit Profile' ),
-                'href'   => $profile_url,
-            )
-        );
-    }
+        )
+    );
 
     $wp_admin_bar->add_node(
@@ -398 +390 @@
             'title' => $title,
             'href'  => ( is_admin() || ! current_user_can( 'read' ) ) ? home_url( '/' ) : admin_url(),
+            'meta' => array(
+                'menu_title' => $title,
+            ),
         )
     );
@@ -995 +990 @@
             'title' => $title,
             'href'  => admin_url( current( array_keys( $actions ) ) ),
+            'meta' => array(
+                'menu_title' => _x( 'New', 'admin bar menu group label' ),
+            ),
         )
     );