Make WordPress Core


Ignore:
Timestamp:
02/26/2024 08:16:09 PM (3 years ago)
Author:
jorbin
Message:

Site icon: Polish up Site Icon on the general settings screen.

This fixes a number of issues, chief among them:

  • Updates to the site title are reflected in the preview.
  • Improve alt text for preview
  • Make string describing site icon more succinct.
  • Add inline documentation to JavaScript

Props kebbet, jorbin, swissspidy, afercia, mukesh27, alexstine, jameskoster, andraganescu.
Fixes #54370.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/options.php

    r56176 r57713  
    3737        jQuery( function($) {
    3838                var $siteName = $( '#wp-admin-bar-site-name' ).children( 'a' ).first(),
     39                        $siteIconPreview = $('#site-icon-preview-site-title'),
    3940                        homeURL = ( <?php echo wp_json_encode( get_home_url() ); ?> || '' ).replace( /^(https?:\/\/)?(www\.)?/, '' );
    4041
    … …  
    4849
    4950                        $siteName.text( title );
     51                        $siteIconPreview.text( title );
    5052                });
    5153
Note: See TracChangeset for help on using the changeset viewer.