Changeset 57750 for trunk/src/wp-includes/class-wp-query.php

Timestamp:

03/02/2024 01:36:02 PM (13 months ago)

Author:

swissspidy

Message:

Query: Remove leading whitespace from certain database queries.

Unintended leading whitespace at the beginning of a raw MySQL query led to unexpected behavior such as broken pagination. Eliminating said whitespace avoids that.

Adds unit tests to prevent regressions.

Props wpfed, swissspidy, ironprogrammer, tadamarketing, afercia.
Fixes #56841.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -3105 +3105 @@
         }
 
-        $old_request = "
-            SELECT $found_rows $distinct $fields
-            FROM {$wpdb->posts} $join
-            WHERE 1=1 $where
-            $groupby
-            $orderby
-            $limits
-        ";
+        // Beginning of the string is on a new line to prevent leading whitespace. See https://core.trac.wordpress.org/ticket/56841.
+        $old_request =
+            "SELECT $found_rows $distinct $fields
+             FROM {$wpdb->posts} $join
+             WHERE 1=1 $where
+             $groupby
+             $orderby
+             $limits";
 
         $this->request = $old_request;
@@ -3308 +3308 @@
                 // First get the IDs and then fill in the objects.
 
-                $this->request = "
-                    SELECT $found_rows $distinct {$wpdb->posts}.ID
-                    FROM {$wpdb->posts} $join
-                    WHERE 1=1 $where
-                    $groupby
-                    $orderby
-                    $limits
-                ";
+                // Beginning of the string is on a new line to prevent leading whitespace. See https://core.trac.wordpress.org/ticket/56841.
+                $this->request =
+                    "SELECT $found_rows $distinct {$wpdb->posts}.ID
+                     FROM {$wpdb->posts} $join
+                     WHERE 1=1 $where
+                     $groupby
+                     $orderby
+                     $limits";
 
                 /**