Changeset 57750 for trunk/src/wp-includes/class-wp-site-query.php

Timestamp:

03/02/2024 01:36:02 PM (2 years ago)

Author:

swissspidy

Message:

Query: Remove leading whitespace from certain database queries.

Unintended leading whitespace at the beginning of a raw MySQL query led to unexpected behavior such as broken pagination. Eliminating said whitespace avoids that.

Adds unit tests to prevent regressions.

Props wpfed, swissspidy, ironprogrammer, tadamarketing, afercia.
Fixes #56841.

File:

• trunk/src/wp-includes/class-wp-site-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-site-query.php

@@ -696 +696 @@
                 $this->sql_clauses['limits']  = $limits;
 
-                $this->request = "
-                        {$this->sql_clauses['select']}
-                        {$this->sql_clauses['from']}
-                        {$where}
-                        {$this->sql_clauses['groupby']}
-                        {$this->sql_clauses['orderby']}
-                        {$this->sql_clauses['limits']}
-                ";
+                // Beginning of the string is on a new line to prevent leading whitespace. See https://core.trac.wordpress.org/ticket/56841.
+                $this->request =
+                        "{$this->sql_clauses['select']}
+                         {$this->sql_clauses['from']}
+                         {$where}
+                         {$this->sql_clauses['groupby']}
+                         {$this->sql_clauses['orderby']}
+                         {$this->sql_clauses['limits']}";
 
                 if ( $this->query_vars['count'] ) {