Changeset 57750 for trunk/src/wp-includes/class-wp-user-query.php

Timestamp:

03/02/2024 01:36:02 PM (13 months ago)

Author:

swissspidy

Message:

Query: Remove leading whitespace from certain database queries.

Unintended leading whitespace at the beginning of a raw MySQL query led to unexpected behavior such as broken pagination. Eliminating said whitespace avoids that.

Adds unit tests to prevent regressions.

Props wpfed, swissspidy, ironprogrammer, tadamarketing, afercia.
Fixes #56841.

File:

• trunk/src/wp-includes/class-wp-user-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-user-query.php

@@ -819 +819 @@
 
         if ( null === $this->results ) {
-            $this->request = "
-                SELECT {$this->query_fields}
-                {$this->query_from}
-                {$this->query_where}
-                {$this->query_orderby}
-                {$this->query_limit}
-            ";
+            // Beginning of the string is on a new line to prevent leading whitespace. See https://core.trac.wordpress.org/ticket/56841.
+            $this->request =
+                "SELECT {$this->query_fields}
+                 {$this->query_from}
+                 {$this->query_where}
+                 {$this->query_orderby}
+                 {$this->query_limit}";
             $cache_value   = false;
             $cache_key     = $this->generate_cache_key( $qv, $this->request );