Changeset 57750 for trunk/tests/phpunit/tests/comment/query.php

Timestamp:

03/02/2024 01:36:02 PM (2 years ago)

Author:

swissspidy

Message:

Query: Remove leading whitespace from certain database queries.

Unintended leading whitespace at the beginning of a raw MySQL query led to unexpected behavior such as broken pagination. Eliminating said whitespace avoids that.

Adds unit tests to prevent regressions.

Props wpfed, swissspidy, ironprogrammer, tadamarketing, afercia.
Fixes #56841.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/comment/query.php

@@ -5351 +5351 @@
         $this->assertStringNotContainsString( ' comment_ID ', $wpdb->last_query );
     }
+
+    /**
+     * @ticket 56841
+     */
+    public function test_query_does_not_have_leading_whitespace() {
+        self::factory()->comment->create(
+            array(
+                'comment_post_ID' => self::$post_id,
+                'user_id'         => 7,
+            )
+        );
+
+        $q = new WP_Comment_Query();
+        $q->query(
+            array(
+                'count'   => true,
+                'orderby' => 'none',
+            )
+        );
+
+        $this->assertSame( ltrim( $q->request ), $q->request, 'The query has leading whitespace' );
+    }
 }