Changeset 57750 for trunk/tests/phpunit/tests/multisite/wpSiteQuery.php

Timestamp:

03/02/2024 01:36:02 PM (3 years ago)

Author:

swissspidy

Message:

Query: Remove leading whitespace from certain database queries.

Unintended leading whitespace at the beginning of a raw MySQL query led to unexpected behavior such as broken pagination. Eliminating said whitespace avoids that.

Adds unit tests to prevent regressions.

Props wpfed, swissspidy, ironprogrammer, tadamarketing, afercia.
Fixes #56841.

File:

• trunk/tests/phpunit/tests/multisite/wpSiteQuery.php (modified) (1 diff)

trunk/tests/phpunit/tests/multisite/wpSiteQuery.php

@@ -1163 +1163 @@
                         return array( get_site( self::$site_ids['wordpress.org/'] ) );
                 }
+
+                /**
+                 * @ticket 56841
+                 */
+                public function test_wp_site_query_does_not_have_leading_whitespace() {
+                        $q = new WP_Site_Query();
+
+                        $q->query(
+                                array(
+                                        'fields'                 => 'ids',
+                                        'network_id'             => self::$network_ids['wordpress.org/'],
+                                        'number'                 => 3,
+                                        'order'                  => 'ASC',
+                                        'update_site_cache'      => true,
+                                        'update_site_meta_cache' => true,
+                                )
+                        );
+
+                        $this->assertSame( ltrim( $q->request ), $q->request, 'The query has leading whitespace' );
+                }
         }