Changeset 57755 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

03/02/2024 08:13:02 PM (11 months ago)

Author:

joedolson

Message:

Media: Accessibility: Copy attachment properties on site icon crop.

Add parity between site icon, custom header, and default image crop behaviors. [53027] fixed a bug where alt text and caption were not copied on custom headers, but did not apply that change in any other context.

Deprecate the create_attachment_object method in the Wp_Site_Icon and Custom_Image_Header classes and replace that functionality with the new function wp_copy_parent_attachment_properties() to improve consistency.

Props afercia, rcreators, jorbin, joedolson, huzaifaalmesbah, shailu25, swissspidy, mukesh27.
Fixes #60524.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (2 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -4036 +4036 @@
 
             /** This filter is documented in wp-admin/includes/class-custom-image-header.php */
-            $cropped    = apply_filters( 'wp_create_file_in_uploads', $cropped, $attachment_id ); // For replication.
-            $attachment = $wp_site_icon->create_attachment_object( $cropped, $attachment_id );
-            unset( $attachment['ID'] );
+            $cropped = apply_filters( 'wp_create_file_in_uploads', $cropped, $attachment_id ); // For replication.
+
+            // Copy attachment properties.
+            $attachment = wp_copy_parent_attachment_properties( $cropped, $attachment_id, $context );
 
             // Update the attachment.
@@ -4066 +4067 @@
             $cropped = apply_filters( 'wp_create_file_in_uploads', $cropped, $attachment_id ); // For replication.
 
-            $parent_url      = wp_get_attachment_url( $attachment_id );
-            $parent_basename = wp_basename( $parent_url );
-            $url             = str_replace( $parent_basename, wp_basename( $cropped ), $parent_url );
-
-            $size       = wp_getimagesize( $cropped );
-            $image_type = ( $size ) ? $size['mime'] : 'image/jpeg';
-
-            // Get the original image's post to pre-populate the cropped image.
-            $original_attachment  = get_post( $attachment_id );
-            $sanitized_post_title = sanitize_file_name( $original_attachment->post_title );
-            $use_original_title   = (
-                ( '' !== trim( $original_attachment->post_title ) ) &&
-                /*
-                 * Check if the original image has a title other than the "filename" default,
-                 * meaning the image had a title when originally uploaded or its title was edited.
-                 */
-                ( $parent_basename !== $sanitized_post_title ) &&
-                ( pathinfo( $parent_basename, PATHINFO_FILENAME ) !== $sanitized_post_title )
-            );
-            $use_original_description = ( '' !== trim( $original_attachment->post_content ) );
-
-            $attachment = array(
-                'post_title'     => $use_original_title ? $original_attachment->post_title : wp_basename( $cropped ),
-                'post_content'   => $use_original_description ? $original_attachment->post_content : $url,
-                'post_mime_type' => $image_type,
-                'guid'           => $url,
-                'context'        => $context,
-            );
-
-            // Copy the image caption attribute (post_excerpt field) from the original image.
-            if ( '' !== trim( $original_attachment->post_excerpt ) ) {
-                $attachment['post_excerpt'] = $original_attachment->post_excerpt;
-            }
-
-            // Copy the image alt text attribute from the original image.
-            if ( '' !== trim( $original_attachment->_wp_attachment_image_alt ) ) {
-                $attachment['meta_input'] = array(
-                    '_wp_attachment_image_alt' => wp_slash( $original_attachment->_wp_attachment_image_alt ),
-                );
-            }
+            // Copy attachment properties.
+            $attachment = wp_copy_parent_attachment_properties( $cropped, $attachment_id, $context );
 
             $attachment_id = wp_insert_attachment( $attachment, $cropped );