Changeset 57755 for trunk/src/wp-admin/includes/class-custom-image-header.php

Timestamp:

03/02/2024 08:13:02 PM (13 months ago)

Author:

joedolson

Message:

Media: Accessibility: Copy attachment properties on site icon crop.

Add parity between site icon, custom header, and default image crop behaviors. [53027] fixed a bug where alt text and caption were not copied on custom headers, but did not apply that change in any other context.

Deprecate the create_attachment_object method in the Wp_Site_Icon and Custom_Image_Header classes and replace that functionality with the new function wp_copy_parent_attachment_properties() to improve consistency.

Props afercia, rcreators, jorbin, joedolson, huzaifaalmesbah, shailu25, swissspidy, mukesh27.
Fixes #60524.

File:

• trunk/src/wp-admin/includes/class-custom-image-header.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-custom-image-header.php

@@ -1078 +1078 @@
         $cropped = apply_filters( 'wp_create_file_in_uploads', $cropped, $attachment_id ); // For replication.
 
-        $attachment = $this->create_attachment_object( $cropped, $attachment_id );
+        $attachment = wp_copy_parent_attachment_properties( $cropped, $attachment_id, 'custom-header' );
 
         if ( ! empty( $_POST['create-new-attachment'] ) ) {
@@ -1315 +1315 @@
      *
      * @since 3.9.0
+     * @deprecated 6.5.0
      *
      * @param string $cropped              Cropped image URL.
@@ -1321 +1322 @@
      */
     final public function create_attachment_object( $cropped, $parent_attachment_id ) {
+        _deprecated_function( __METHOD__, '6.5.0', 'wp_copy_parent_attachment_properties()' );
         $parent     = get_post( $parent_attachment_id );
         $parent_url = wp_get_attachment_url( $parent->ID );
@@ -1422 +1424 @@
         $cropped = apply_filters( 'wp_create_file_in_uploads', $cropped, $attachment_id ); // For replication.
 
-        $attachment = $this->create_attachment_object( $cropped, $attachment_id );
+        $attachment = wp_copy_parent_attachment_properties( $cropped, $attachment_id, 'custom-header' );
 
         $previous = $this->get_previous_crop( $attachment );