Changeset 57755 for trunk/tests/phpunit/tests/image/siteIcon.php

Timestamp:

03/02/2024 08:13:02 PM (2 years ago)

Author:

joedolson

Message:

Media: Accessibility: Copy attachment properties on site icon crop.

Add parity between site icon, custom header, and default image crop behaviors. [53027] fixed a bug where alt text and caption were not copied on custom headers, but did not apply that change in any other context.

Deprecate the create_attachment_object method in the Wp_Site_Icon and Custom_Image_Header classes and replace that functionality with the new function wp_copy_parent_attachment_properties() to improve consistency.

Props afercia, rcreators, jorbin, joedolson, huzaifaalmesbah, shailu25, swissspidy, mukesh27.
Fixes #60524.

File:

• trunk/tests/phpunit/tests/image/siteIcon.php (modified) (2 diffs)

trunk/tests/phpunit/tests/image/siteIcon.php

@@ -99 +99 @@
     }
 
-    public function test_create_attachment_object() {
-        $attachment_id = $this->insert_attachment();
-        $parent_url    = get_post( $attachment_id )->guid;
-        $cropped       = str_replace( wp_basename( $parent_url ), 'cropped-test-image.jpg', $parent_url );
-
-        $object = $this->wp_site_icon->create_attachment_object( $cropped, $attachment_id );
-
-        $this->assertSame( $object['post_title'], 'cropped-test-image.jpg' );
-        $this->assertSame( $object['context'], 'site-icon' );
-        $this->assertSame( $object['post_mime_type'], 'image/jpeg' );
-        $this->assertSame( $object['post_content'], $cropped );
-        $this->assertSame( $object['guid'], $cropped );
-    }
-
     public function test_insert_cropped_attachment() {
         $attachment_id = $this->insert_attachment();
@@ -118 +104 @@
         $cropped       = str_replace( wp_basename( $parent_url ), 'cropped-test-image.jpg', $parent_url );
 
-        $object     = $this->wp_site_icon->create_attachment_object( $cropped, $attachment_id );
+        $object     = wp_copy_parent_attachment_properties( $cropped, $attachment_id, 'site-icon' );
         $cropped_id = $this->wp_site_icon->insert_attachment( $object, $cropped );