Changeset 57763

Timestamp:

03/04/2024 03:52:04 PM (9 months ago)

Author:

swissspidy

Message:

I18N: Cast magic MO marker number to integer.

In gettext, 0x950412de is used to signal GNU MO files. In WP_Translation_File_MO this magic marker is used to detect whether a file uses little endian or big endian.

On 32 bit systems, this number will be interpreted by PHP as a float rather than an integer. This change adds extra casting to force an integer.

A similar change was done in the pomo library in the past, see #3780.

Props tmatsuur, swissspidy.
Fixes #60678.

File:

• trunk/src/wp-includes/l10n/class-wp-translation-file-mo.php (modified) (2 diffs)

trunk/src/wp-includes/l10n/class-wp-translation-file-mo.php

@@ -67 +67 @@
         }
 
-        if ( self::MAGIC_MARKER === $big ) {
+        // Force cast to an integer as it can be a float on x86 systems. See https://core.trac.wordpress.org/ticket/60678.
+        if ( (int) self::MAGIC_MARKER === $big ) {
             return 'N';
         }
 
-        if ( self::MAGIC_MARKER === $little ) {
+        // Force cast to an integer as it can be a float on x86 systems. See https://core.trac.wordpress.org/ticket/60678.
+        if ( (int) self::MAGIC_MARKER === $little ) {
             return 'V';
         }
@@ -204 +206 @@
         $entry_offsets     = $hash_addr;
 
-        $file_header = pack( $this->uint32 . '*', self::MAGIC_MARKER, 0 /* rev */, $entry_count, $originals_addr, $translations_addr, 0 /* hash_length */, $hash_addr );
+        $file_header = pack(
+            $this->uint32 . '*',
+            // Force cast to an integer as it can be a float on x86 systems. See https://core.trac.wordpress.org/ticket/60678.
+            (int) self::MAGIC_MARKER,
+            0, /* rev */
+            $entry_count,
+            $originals_addr,
+            $translations_addr,
+            0, /* hash_length */
+            $hash_addr
+        );
 
         $o_entries = '';