Changeset 57765 for trunk/src/wp-includes/admin-bar.php

Timestamp:

03/04/2024 09:48:29 PM (2 years ago)

Author:

joedolson

Message:

Toolbar: Polish design and code combining duplicate profile links.

Fixes some design changes and improves quality of comments and code styles following previous changes. Follow-up to [57708].

Props sabernhardt, huzaifaalmesbah, joedolson.
Fixes #43633. See #34668.

File:

• trunk/src/wp-includes/admin-bar.php (modified) (5 diffs)

trunk/src/wp-includes/admin-bar.php

@@ -140 +140 @@
                         '</span>',
                 'href'  => $about_url,
-                'meta' => array(
+                'meta'  => array(
                         'menu_title' => __( 'About WordPress' ),
                 ),
@@ -287 +287 @@
                         'meta'   => array(
                                 'class'      => $class,
+                                /* translators: %s: Current user's display name. */
                                 'menu_title' => sprintf( __( 'Howdy, %s' ), $current_user->display_name ),
+                                'tabindex'   => ( false !== $profile_url ) ? '' : 0,
                         ),
                 )
@@ -330 +332 @@
         }
 
-        $user_info .= "<span class='edit-profile'>" . __( 'Edit Profile' ) . '</span>';
+        if ( false !== $profile_url ) {
+                $user_info .= "<span class='display-name edit-profile'>" . __( 'Edit Profile' ) . '</span>';
+        }
 
         $wp_admin_bar->add_node(
@@ -390 +394 @@
                         'title' => $title,
                         'href'  => ( is_admin() || ! current_user_can( 'read' ) ) ? home_url( '/' ) : admin_url(),
-                        'meta' => array(
+                        'meta'  => array(
                                 'menu_title' => $title,
                         ),
@@ -991 +995 @@
                         'title' => $title,
                         'href'  => admin_url( current( array_keys( $actions ) ) ),
-                        'meta' => array(
+                        'meta'  => array(
                                 'menu_title' => _x( 'New', 'admin bar menu group label' ),
                         ),