Changeset 57769 for trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

Timestamp:

03/05/2024 06:25:22 AM (13 months ago)

Author:

desrosj

Message:

Plugins: Improve plugin dependency admin notices.

This makes several refinements to the various notices displayed in the WordPress admin related to plugin dependencies. Additionally, it adds some conditions to display more appropriate messages for multisite installs with proper context to the user’s capabilities.

Props costdev, joedolson, afragen, swissspidy, peterwilsoncc, euthelup.
Fixes #60465.

File:

• trunk/src/wp-admin/includes/class-wp-plugins-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -1568 +1568 @@
         }
 
-        $dependency_note = __( 'Note: This plugin cannot be activated until the plugins that are required by it are activated.' );
-
-        $comma    = wp_get_list_item_separator();
-        $requires = sprintf(
+        $is_active = is_multisite() ? is_plugin_active_for_network( $dependent ) : is_plugin_active( $dependent );
+        $comma     = wp_get_list_item_separator();
+        $requires  = sprintf(
             /* translators: %s: List of dependency names. */
             __( '<strong>Requires:</strong> %s' ),
@@ -1577 +1576 @@
         );
 
+        $notice        = '';
+        $error_message = '';
+        if ( WP_Plugin_Dependencies::has_unmet_dependencies( $dependent ) ) {
+            if ( $is_active ) {
+                $error_message = __( 'This plugin is active but may not function correctly because required plugins are missing or inactive.' );
+            } else {
+                $error_message = __( 'This plugin cannot be activated because required plugins are missing or inactive.' );
+            }
+            $notice = wp_get_admin_notice(
+                $error_message,
+                array(
+                    'type'               => 'error',
+                    'additional_classes' => array( 'inline', 'notice-alt' ),
+                )
+            );
+        }
+
         printf(
             '<div class="requires"><p>%1$s</p><p>%2$s</p></div>',
             $requires,
-            $dependency_note
+            $notice
         );
     }