Changeset 57776

Timestamp:

03/05/2024 02:26:01 PM (8 weeks ago)

Author:

audrasjb

Message:

Plugins: Fix an overlap issue with plugin cards dependencies notice.

This changeset fixes an issue where plugin card dependencies notice and plugin icon were overlapping in some cases.

Props costdev, euthelup, shailu25, desrosj, swissspidy, audrasjb.
Fixes #60501.

Location:

trunk/src/wp-admin

Files:

• css/list-tables.css (modified) (1 diff)
• includes/class-wp-plugin-install-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/css/list-tables.css

@@ -1596 +1596 @@
 }
 
-.plugin-card .plugin-dependencies {
-    background-color: #e5f5fa;
-    border-left: 3px solid #72aee6;
-    margin-bottom: .5em;
+.plugin-card .notice.plugin-dependencies {
+    margin: auto 20px 20px;
     padding: 15px;
 }

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -674 +674 @@
                     <p class="authors"><?php echo $author; ?></p>
                 </div>
-                <?php echo $this->get_dependencies_notice( $plugin ); ?>
             </div>
+            <?php
+            $dependencies_notice = $this->get_dependencies_notice( $plugin );
+            if ( ! empty( $dependencies_notice ) ) {
+                echo $dependencies_notice;
+            }
+            ?>
             <div class="plugin-card-bottom">
                 <div class="vers column-rating">
@@ -781 +786 @@
 
         $dependencies_notice = sprintf(
-            '<div class="plugin-dependencies"><p class="plugin-dependencies-explainer-text">%s</p> %s</div>',
+            '<div class="plugin-dependencies notice notice-alt notice-info inline"><p class="plugin-dependencies-explainer-text">%s</p> %s</div>',
             '<strong>' . __( 'Additional plugins are required' ) . '</strong>',
             $dependencies_list