Changeset 57795

Timestamp:

03/09/2024 01:07:52 AM (16 months ago)

Author:

desrosj

Message:

Build/Test Tools: Do not run Props Bot for certain actions from forks.

For PRs that originate from forked repositories, pull_request_review and pull_request_review_comment events do not have the permissions necessary to comment on the PR.

This avoids needlessly running the bot when these conditions are met.

Props jorbin, wildworks.
See #60733.

File:

• trunk/.github/workflows/props-bot.yml (modified) (2 diffs)

trunk/.github/workflows/props-bot.yml

@@ -58 +58 @@
     #
     # - A comment is added to the pull request.
-    # - A review is created or commented on.
+    # - A review is created or commented on (unless PR originates from a fork).
     # - The pull request is opened, synchronized, marked ready for review, or reopened.
     # - The `props-bot` label is added to the pull request.
@@ -64 +64 @@
       (
         github.event_name == 'issue_comment' && github.event.issue.pull_request ||
-        contains( fromJSON( '["pull_request_review", "pull_request_review_comment"]' ), github.event_name ) ||
+        ( contains( fromJSON( '["pull_request_review", "pull_request_review_comment"]' ), github.event_name ) && ! github.event.pull_request.head.repo.fork ) ||
         github.event_name == 'pull_request_target' && github.event.action != 'labeled' ||
         'props-bot' == github.event.label.name