Changeset 57815 for branches/6.5/tests/phpunit/tests/html-api/wpHtmlTagProcessor-bookmark.php

Timestamp:

03/12/2024 02:25:30 PM (20 months ago)

Author:

audrasjb

Message:

HTML API: Defer applying attribute updates until necessary.

When making repeated updates to a document, the Tag Processor will end
up copying the entire document once for every update. This can lead to
catastrophic behavior in the worse case.

However, when batch-applying updates it's able to copy chunks of the
document in one thread and only end up copying the entire document once
for the entire batch.

Previously the Tag Processor has been eagerly applying udpates, but in
this patch it defers applying those updates as long as is possible.
Developed in ​https://github.com/WordPress/wordpress-develop/pull/6120
Discussed in https://core.trac.wordpress.org/ticket/60697

Follow-up to [55706], [56941], [57348].

Reviewed by swissspidy.
Merges [57805] to the to the 6.5 branch.

Props dmsnell, bernhard-reiter, jonsurrell, westonruter.
Fixes #60697.

Location:

branches/6.5

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/html-api/wpHtmlTagProcessor-bookmark.php (modified) (3 diffs)

branches/6.5/tests/phpunit/tests/html-api/wpHtmlTagProcessor-bookmark.php

@@ -294 +294 @@
     /**
      * @ticket 56299
+     * @ticket 60697
      *
      * @covers WP_HTML_Tag_Processor::seek
@@ -300 +301 @@
         $processor = new WP_HTML_Tag_Processor( '<div>First</div><div>Second</div>' );
         $processor->next_tag();
-        $processor->set_bookmark( 'first' );
-        $processor->next_tag();
+        $processor->set_attribute( 'id', 'one' );
+        $processor->set_bookmark( 'first' );
+        $processor->next_tag();
+        $processor->set_attribute( 'id', 'two' );
         $processor->add_class( 'second' );
 
@@ -308 +311 @@
 
         $this->assertSame(
-            '<div class="first">First</div><div class="second">Second</div>',
+            'one',
+            $processor->get_attribute( 'id' ),
+            'Should have remembered attribute change from before the seek.'
+        );
+
+        $this->assertSame(
+            '<div class="first" id="one">First</div><div class="second" id="two">Second</div>',
             $processor->get_updated_html(),
             'The bookmark was updated incorrectly in response to HTML markup updates'