Changeset 57834 for branches/6.5/tests/phpunit/tests/interactivity-api/interactivity-api.php

Timestamp:

03/14/2024 03:10:55 PM (3 years ago)

Author:

swissspidy

Message:

Interactivity API: Do not propagate context from void tags to its siblings.

Resolves an issue where context on a void tag element such as <img> was incorrectly passed to following elements.
Adds tests.

Reviewed by gziolo.
Merges [57832] to the to the 6.5 branch.

Props santosguillamot, luisherranz, cbravobernal, dmsnell, gziolo, swissspidy.
Fixes #60768.

Location:

branches/6.5

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/interactivity-api/interactivity-api.php (modified) (1 diff)

branches/6.5/tests/phpunit/tests/interactivity-api/interactivity-api.php

@@ -424 +424 @@
                 $this->assertEquals( 'data-wp-context=\'{"amp":"T\u0026T"}\'', wp_interactivity_data_wp_context( array( 'amp' => 'T&T' ) ) );
         }
+
+        /**
+         * Tests that context from void tags is not propagated to next tags.
+         *
+         * @ticket 60768
+         *
+         * @covers wp_interactivity_process_directives_of_interactive_blocks
+         */
+        public function test_process_context_directive_in_void_tags() {
+                register_block_type(
+                        'test/custom-directive-block',
+                        array(
+                                'render_callback' => function () {
+                                        return '<div data-wp-interactive="nameSpace" data-wp-context=\'{"text": "outer"}\'><input id="first-input" data-wp-context=\'{"text": "inner"}\' data-wp-bind--value="context.text" /><input id="second-input" data-wp-bind--value="context.text" /></div>';
+                                },
+                                'supports'        => array(
+                                        'interactivity' => true,
+                                ),
+                        )
+                );
+                $post_content      = '<!-- wp:test/custom-directive-block /-->';
+                $processed_content = do_blocks( $post_content );
+                $processor         = new WP_HTML_Tag_Processor( $processed_content );
+                $processor->next_tag(
+                        array(
+                                'tag_name' => 'input',
+                                'id'       => 'first-input',
+                        )
+                );
+                $first_input_value = $processor->get_attribute( 'value' );
+                $processor->next_tag(
+                        array(
+                                'tag_name' => 'input',
+                                'id'       => 'second-input',
+                        )
+                );
+                $second_input_value = $processor->get_attribute( 'value' );
+                unregister_block_type( 'test/custom-directive-block' );
+                $this->assertEquals( 'inner', $first_input_value );
+                $this->assertEquals( 'outer', $second_input_value );
+        }
+
+        /**
+         * Tests that namespace from void tags is not propagated to next tags.
+         *
+         * @ticket 60768
+         *
+         * @covers wp_interactivity_process_directives_of_interactive_blocks
+         */
+        public function test_process_interactive_directive_in_void_tags() {
+                wp_interactivity_state(
+                        'void',
+                        array(
+                                'text' => 'void',
+                        )
+                );
+                register_block_type(
+                        'test/custom-directive-block',
+                        array(
+                                'render_callback' => function () {
+                                        return '<div data-wp-interactive="parent"><img data-wp-interactive="void" /><input data-wp-bind--value="state.text" /></div>';
+                                },
+                                'supports'        => array(
+                                        'interactivity' => true,
+                                ),
+                        )
+                );
+                $post_content      = '<!-- wp:test/custom-directive-block /-->';
+                $processed_content = do_blocks( $post_content );
+                $processor         = new WP_HTML_Tag_Processor( $processed_content );
+                $processor->next_tag( array( 'tag_name' => 'input' ) );
+                $input_value = $processor->get_attribute( 'value' );
+                unregister_block_type( 'test/custom-directive-block' );
+                $this->assertNull( $input_value );
+        }
 }