Changeset 57837 for branches/6.5/src/wp-includes/interactivity-api/class-wp-interactivity-api.php

Timestamp:

03/15/2024 11:15:56 AM (14 months ago)

Author:

swissspidy

Message:

Interactivity API: Prevent warning when using a bind directive with a short attribute name.

Adds new tests and improves existing ones by using assertSame to do type comparison as well.

Reviewed by gziolo.
Merges [57835] to the to the 6.5 branch.

Props jonsurrell, cbravobernal, swissspidy, gziolo.
Fixes #60758.

Location:

branches/6.5

Files:

• . (modified) (1 prop)
• src/wp-includes/interactivity-api/class-wp-interactivity-api.php (modified) (2 diffs)

branches/6.5/src/wp-includes/interactivity-api/class-wp-interactivity-api.php

@@ -592 +592 @@
                 $result          = $this->evaluate( $attribute_value, end( $namespace_stack ), end( $context_stack ) );
 
-                if ( null !== $result && ( false !== $result || '-' === $bound_attribute[4] ) ) {
+                if (
+                    null !== $result &&
+                    (
+                        false !== $result ||
+                        ( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] )
+                    )
+                ) {
                     /*
                      * If the result of the evaluation is a boolean and the attribute is
@@ -600 +606 @@
                      * https://github.com/preactjs/preact/blob/ea49f7a0f9d1ff2c98c0bdd66aa0cbc583055246/src/diff/props.js#L131C24-L136
                      */
-                    if ( is_bool( $result ) && '-' === $bound_attribute[4] ) {
+                    if (
+                        is_bool( $result ) &&
+                        ( strlen( $bound_attribute ) > 5 && '-' === $bound_attribute[4] )
+                    ) {
                         $result = $result ? 'true' : 'false';
                     }