Changeset 57839

Timestamp:

03/15/2024 11:23:18 AM (2 years ago)

Author:

swissspidy

Message:

REST API: Prevent error when passing invalid type parameter to search endpoint.

In WP_REST_Search_Controller, the type parameter is accessed via the sanitization callback for the subtype parameter, which is too early for type itself to be already sanitized. This change adds a type check in the get_search_handler() method to prevent errors when the type doesn’t match.

Props swissspidy, timothyblynjacobs, dd32.
Fixes #60771.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-search-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-search-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-search-controller.php

@@ -396 +396 @@
                 $type = $request->get_param( self::PROP_TYPE );
 
-                if ( ! $type || ! isset( $this->search_handlers[ $type ] ) ) {
+                if ( ! $type || ! is_string( $type ) || ! isset( $this->search_handlers[ $type ] ) ) {
                         return new WP_Error(
                                 'rest_search_invalid_type',

trunk/tests/phpunit/tests/rest-api/rest-search-controller.php

@@ -889 +889 @@
                 );
         }
+
+        /**
+         * @ticket 60771
+         */
+        public function test_sanitize_subtypes_validates_type() {
+                $response = $this->do_request_with_params(
+                        array(
+                                'subtype' => 'page',
+                                'type'    => array( 'invalid' ),
+                        )
+                );
+
+                $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+        }
 }