Changeset 57839 for trunk/tests/phpunit/tests/rest-api/rest-search-controller.php

Timestamp:

03/15/2024 11:23:18 AM (15 months ago)

Author:

swissspidy

Message:

REST API: Prevent error when passing invalid type parameter to search endpoint.

In WP_REST_Search_Controller, the type parameter is accessed via the sanitization callback for the subtype parameter, which is too early for type itself to be already sanitized. This change adds a type check in the get_search_handler() method to prevent errors when the type doesn’t match.

Props swissspidy, timothyblynjacobs, dd32.
Fixes #60771.

File:

• trunk/tests/phpunit/tests/rest-api/rest-search-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-search-controller.php

@@ -889 +889 @@
         );
     }
+
+    /**
+     * @ticket 60771
+     */
+    public function test_sanitize_subtypes_validates_type() {
+        $response = $this->do_request_with_params(
+            array(
+                'subtype' => 'page',
+                'type'    => array( 'invalid' ),
+            )
+        );
+
+        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
+    }
 }